From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1907 invoked by alias); 13 Aug 2014 18:28:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1892 invoked by uid 89); 13 Aug 2014 18:28:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Aug 2014 18:28:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7DISBdm018921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Aug 2014 14:28:12 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7DISBAR028413; Wed, 13 Aug 2014 14:28:11 -0400 Message-ID: <53EBAE3B.6080101@redhat.com> Date: Wed, 13 Aug 2014 18:28:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 060/236] cfgrtl.c: Use rtx subclasses References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-61-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-61-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01364.txt.bz2 On 08/06/14 11:20, David Malcolm wrote: > gcc/ > * cfgrtl.c (can_delete_note_p): Require a const rtx_note * rather > than a const_rtx. > (can_delete_label_p): Require a const rtx_code_label * rather than > a const_rtx. > (delete_insn): Add checked cast to rtx_code_label * when we know > we're dealing with LABEL_P (insn). Strengthen local "bb_note" from > rtx to rtx_insn *. > (delete_insn_chain): Strengthen locals "prev" and "current" from > rtx to rtx_insn *. Add a checked cast when assigning from > "finish" (strengthening the params will come later). Add a > checked cast to rtx_note * in region where we know > NOTE_P (current). > (rtl_delete_block): Strengthen locals "insn" and "end" from rtx to > rtx_insn *. > (compute_bb_for_insn): Likewise. > (free_bb_for_insn): Likewise for local "insn". > (compute_bb_for_insn): Likewise. > (update_bb_for_insn_chain): Strengthen params "begin", "end" and > local "insn" from rtx to rtx_insn * > (flow_active_insn_p): Require a const rtx_insn * rather than a > const_rtx. > (contains_no_active_insn_p): Strengthen local "insn" from rtx to > rtx_insn *. > (can_fallthru): Likewise for locals "insn" and "insn2". > (bb_note): Likewise for local "note". > (first_insn_after_basic_block_note): Likewise for local "note" and > for return type. > (rtl_split_block): Likewise for locals "insn" and "next". > (unique_locus_on_edge_between_p): Likewise for locals "insn" and > "end". > (rtl_merge_blocks): Likewise for locals "b_head", "b_end", > "a_end", "del_first", "del_last", "b_debug_start", "b_debug_end", > "prev", "tmp". > (try_redirect_by_replacing_jump): Likewise for locals "insn" (both of > them), "kill_from", "barrier", "new_insn". > (patch_jump_insn): Likewise for params "insn", "old_label". > (redirect_branch_edge): Likewise for locals "old_label", "insn". > (force_nonfallthru_and_redirect): Likewise for locals "insn", > "old_label", "new_label". > (rtl_tidy_fallthru_edge): Likewise for local "q". > (rtl_split_edge): Likewise for locals "before", "last". > (commit_one_edge_insertion): Likewise for locals "before", > "after", "insns", "tmp", "last", adding a checked cast where > currently necessary. > (commit_edge_insertions): Likewise. > (rtl_dump_bb): Likewise for locals "insn", "last". > (print_rtl_with_bb): Likewise for local "x". > (rtl_verify_bb_insns): Likewise for local "x". > (rtl_verify_bb_pointers): Likewise for local "insn". > (rtl_verify_bb_insn_chain): Likewise for locals "x", "last_head", > "head", "end". > (rtl_verify_fallthru): Likewise for local "insn". > (rtl_verify_bb_layout): Likewise for locals "x" and "rtx_first". > (purge_dead_edges): Likewise for local "insn". > (fixup_abnormal_edges): Likewise for locals "insn", "stop", "next". > (skip_insns_after_block): Likewise for return type and for locals > "insn", "last_insn", "next_head", "prev". > (record_effective_endpoints): Likewise for locals "next_insn", > "insn", "end". > (fixup_reorder_chain): Likewise for locals "bb_end_insn" and "end". > (verify_insn_chain): Likewise for locals "x", "prevx", "nextx". > (cfg_layout_can_duplicate_bb_p): Likewise for local "insn". > (duplicate_insn_chain): For now, add checked cast from rtx to > rtx_insn * when returning insn. > (cfg_layout_duplicate_bb): Likewise for local "insn". > (cfg_layout_delete_block): Likewise for locals "insn", "next", > "prev", "remaints". > (cfg_layout_merge_blocks): Likewise for local "insn", "last". > (rtl_block_empty_p): Likewise. > (rtl_split_block_before_cond_jump): Likewise for locals "insn", > "split_point", "last". > (rtl_block_ends_with_call_p): Likewise for local "insn". > (need_fake_edge_p): Strengthen param "insn" from const_rtx to > const rtx_insn *. > (rtl_flow_call_edges_add): Strengthen locals "insn", "prev_insn", > "split_at_insn" from rtx to rtx_insn *. > (rtl_lv_add_condition_to_bb): Likewise for locals "seq", "jump". > (rtl_can_remove_branch_p): Strengthen local "insn" from const_rtx > to const rtx_insn *. > (rtl_account_profile_record): Likewise. > --- OK. Jeff