From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15794 invoked by alias); 13 Aug 2014 18:46:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15783 invoked by uid 89); 13 Aug 2014 18:46:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Aug 2014 18:46:02 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7DIk0oX030950 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Aug 2014 14:46:00 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7DIjxMh013147; Wed, 13 Aug 2014 14:45:59 -0400 Message-ID: <53EBB267.6010502@redhat.com> Date: Wed, 13 Aug 2014 18:46:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 061/236] combine.c: Use rtx_insn References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-62-git-send-email-dmalcolm@redhat.com> <53EBB0F3.5030803@redhat.com> In-Reply-To: <53EBB0F3.5030803@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01367.txt.bz2 On 08/13/14 12:39, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: >> gcc/ >> * combine.c (i2mod): Strengthen this variable from rtx to rtx_insn *. >> (struct reg_stat_struct): Likewise for fields "last_death", >> "last_set". >> (subst_insn): Likewise for this variable. >> (added_links_insn): Likewise. >> (struct insn_link): Likewise for field "insn". >> (alloc_insn_link): Likewise for param "insn". >> (struct undobuf): Likewise for field "other_insn". >> (find_single_use): Likewise for param "insn" and local "next". >> (combine_validate_cost): Likewise for params "i0", "i1", "i2", "i3". >> (delete_noop_moves): Likewise for locals "insn", "next". >> (create_log_links): Likewise for locals "insn", "use_insn". >> Strengthen local "next_use" from rtx * to rtx_insn **. >> (insn_a_feeds_b): Likewise for params "a", "b". >> (combine_instructions): Likewise for param "f" and locals "insn", >> "next", "prev", "first", "last_combined_insn", "link", "link1", >> "temp". Replace use of NULL_RTX with NULL when referring to >> insns. >> (setup_incoming_promotions): Likewise for param "first" >> (set_nonzero_bits_and_sign_copies): Likewise for local "insn". >> (can_combine_p): Likewise for params "insn", "i3", "pred", >> "pred2", "succ", "succ2" and for local "p". >> (combinable_i3pat): Likewise for param "i3". >> (cant_combine_insn_p): Likewise for param "insn". >> (likely_spilled_retval_p): Likewise. >> (adjust_for_new_dest): Likewise. >> (update_cfg_for_uncondjump): Likewise, also for local "insn". >> (try_combine): Likewise for return type and for params "i3", "i2", >> "i1", "i0", "last_combined_insn", and for locals "insn", >> "cc_use_insn", "p", "first", "last", "i2_insn", "i1_insn", >> "i0_insn". Eliminate local "tem" in favor of new locals >> "tem_note" and "tem_insn", the latter being an rtx_insn *. Add a >> checked cast for now to rtx_insn * on the return type of >> gen_rtx_INSN. Replace use of NULL_RTX with NULL when referring to >> insns. >> (find_split_point): Strengthen param "insn" from rtx to >> rtx_insn *. >> (simplify_set): Likewise for local "other_insn". >> (recog_for_combine): Likewise for param "insn". >> (record_value_for_reg): Likewise. >> (record_dead_and_set_regs_1): Likewise for local >> "record_dead_insn". >> (record_dead_and_set_regs): Likewise for param "insn". >> (record_promoted_value): Likewise. >> (check_promoted_subreg): Likewise. >> (get_last_value_validate): Likewise. >> (reg_dead_at_p): Likewise. >> (move_deaths): Likewise for param "to_insn". >> (distribute_notes): Likewise for params "from_insn", "i3", "i2" >> and locals "place", "place2", "cc0_setter". Eliminate local "tem >> in favor of new locals "tem_note" and "tem_insn", the latter being >> an rtx_insn *. >> (distribute_links): Strengthen locals "place", "insn" from rtx to >> rtx_insn *. >> --- > OK. > > As are patches #62- This should have been #62-#74. Jeff