From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1297 invoked by alias); 13 Aug 2014 19:47:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1284 invoked by uid 89); 13 Aug 2014 19:47:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Aug 2014 19:47:21 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7DJlJ9w029660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Aug 2014 15:47:20 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7DJlJ4F004211; Wed, 13 Aug 2014 15:47:19 -0400 Message-ID: <53EBC0C7.9040404@redhat.com> Date: Wed, 13 Aug 2014 19:47:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 075/236] final.c: Use rtx_insn (also touches output.c and config/arc/arc.c) References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-76-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-76-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01375.txt.bz2 On 08/06/14 11:20, David Malcolm wrote: > In particular, after this patch, the first param passed to the > FINAL_PRESCAN_INSN macro is strengthened from rtx to rtx_insn *. > > gcc/ > * output.h (final_scan_insn): Strengthen return type from rtx to > rtx_insn *. > (final_forward_branch_p): Likewise for param. > (current_output_insn): Likewise for this global. > > * final.c (rtx debug_insn): Likewise for this variable. > (current_output_insn): Likewise. > (get_attr_length_1): Rename param "insn" to "uncast_insn", > adding "insn" back in as an rtx_insn * with a checked cast, so > that macro ADJUST_INSN_LENGTH can be passed an rtx_insn * as the > first param. > (compute_alignments): Strengthen local "label" from rtx to > rtx_insn *. > (shorten_branches): Rename param from "first" to "uncast_first", > introducing a new local rtx_insn * "first" using a checked cast to > effectively strengthen "first" from rtx to rtx_insn * without > affecting the type signature. Strengthen locals "insn", "seq", > "next", "label" from rtx to rtx_insn *. > (change_scope): Strengthen param "orig_insn" and local "insn" from > rtx to rtx_insn *. > (final_start_function): Rename param from "first" to "uncast_first", > introducing a new local rtx_insn * "first" using a checked cast to > effectively strengthen "first" from rtx to rtx_insn * without > affecting the type signature. Strengthen local "insn" from rtx to > rtx_insn *. > (dump_basic_block_info): Strengthen param "insn" from rtx to > rtx_insn *. > (final): Rename param from "first" to "uncast_first", > introducing a new local rtx_insn * "first" using a checked cast to > effectively strengthen "first" from rtx to rtx_insn * without > affecting the type signature. Strengthen locals "insn", "next" > from rtx to rtx_insn *. > (output_alternate_entry_point): Strengthen param "insn" from rtx to > rtx_insn *. > (call_from_call_insn): Strengthen param "insn" from rtx to > rtx_call_insn *. > (final_scan_insn): Rename param from "insn" to "uncast_insn", > introducing a new local rtx_insn * "insn" using a checked cast to > effectively strengthen "insn" from rtx to rtx_insn * without > affecting the type signature. Strengthen return type and locals > "next", "note", "prev", "new_rtx" from rtx to rtx_insn *. Remove > now-redundant checked cast to rtx_insn * from both invocations of > debug_hooks->var_location. Convert CALL_P into a dyn_cast, > introducing a local "call_insn" for use when invoking > call_from_call_insn. > (notice_source_line): Strengthen param "insn" from rtx to > rtx_insn *. > (leaf_function_p): Likewise for local "insn". > (final_forward_branch_p): Likewise. > (leaf_renumber_regs): Likewise for param "first". > (rest_of_clean_state): Likewise for locals "insn" and "next". > (collect_fn_hard_reg_usage): Likewise for local "insn". > (get_call_fndecl): Likewise for param "insn". > (get_call_cgraph_rtl_info): Likewise. > (get_call_reg_set_usage): Rename param from "insn" to "uncast_insn", > introducing a new local rtx_insn * "insn" using a checked cast to > effectively strengthen "insn" from rtx to rtx_insn * without > affecting the type signature. > > * config/arc/arc.c (arc_final_prescan_insn): For now, add checked > cast when assigning from param "insn" to current_output_insn. > (arc_pad_return): Strengthen local "insn" from rtx to rtx_insn * > so that we can assign it back to current_output_insn. OK. I didn't check all the uncast_XXX thingies, but at least some of them go away in later patches. Presumably you verified the uncast_XXX thingies all go away in the end :-) Patches #76-#91 are OK as well. jeff