From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29424 invoked by alias); 13 Aug 2014 20:25:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29410 invoked by uid 89); 13 Aug 2014 20:25:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Aug 2014 20:25:01 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7DKOxxl013540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Aug 2014 16:25:00 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7DKOxmP031691; Wed, 13 Aug 2014 16:24:59 -0400 Message-ID: <53EBC99B.3060501@redhat.com> Date: Wed, 13 Aug 2014 20:25:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 190/236] Remove insn_addresses_new from 'various scheduling strengthenings' References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-191-git-send-email-dmalcolm@redhat.com> <1407958321.28418.142.camel@surprise> In-Reply-To: <1407958321.28418.142.camel@surprise> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01380.txt.bz2 On 08/13/14 13:32, David Malcolm wrote: > On Wed, 2014-08-06 at 13:22 -0400, David Malcolm wrote: >> --- >> gcc/insn-addr.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/insn-addr.h b/gcc/insn-addr.h >> index e255ac4..aec09fd 100644 >> --- a/gcc/insn-addr.h >> +++ b/gcc/insn-addr.h >> @@ -38,7 +38,7 @@ extern int insn_current_address; >> #define INSN_ADDRESSES_SIZE() (insn_addresses_.length ()) >> >> static inline void >> -insn_addresses_new (rtx_insn *insn, int insn_addr) >> +insn_addresses_new (rtx insn, int insn_addr) >> { >> unsigned insn_uid = INSN_UID ((insn)); > > Oops; this one undoes part of patch 189. I think I meant to squash > these two together, since without 190, 189 breaks the build on s390 in a > few places. NP. Track that however you want. No need to repost everything right now. Though I do request that you post final versions for archival purposes. Jeff