From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10980 invoked by alias); 14 Aug 2014 02:43:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10951 invoked by uid 89); 14 Aug 2014 02:43:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 Aug 2014 02:43:25 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7E2hMoq024069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Aug 2014 22:43:23 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7E2hM5P032396; Wed, 13 Aug 2014 22:43:22 -0400 Message-ID: <53EC224A.8070508@redhat.com> Date: Thu, 14 Aug 2014 02:43:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 108/236] reload: Use rtx_insn (also touches caller-save.c and config/arc/arc) References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-109-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-109-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01418.txt.bz2 On 08/06/14 11:21, David Malcolm wrote: > gcc/ > * reload.h (struct insn_chain): Strengthen field "insn" from rtx > to rtx_insn *. > (find_reloads): Likewise for param 1. > (subst_reloads): Likewise for sole param. > (find_equiv_reg): Likwise for param 2. > (regno_clobbered_p): Likwise for param 2. > (reload): Likewise for param 1. > > * caller-save.c (save_call_clobbered_regs): Strengthen local > "insn" from rtx to rtx_insn *. > (insert_one_insn): Likewise for local "insn". > > * reload.c (this_insn): Likewise for this global. > (find_reloads): Likewise for param "insn". > (find_reloads_toplev): Likewise. > (find_reloads_address): Likewise. > (subst_reg_equivs): Likewise. > (update_auto_inc_notes): Likewise. > (find_reloads_address_1): Likewise. > (find_reloads_subreg_address): Likewise. > (subst_reloads): Likewise. > (find_equiv_reg): Likewise, also for local "p". > (regno_clobbered_p): Likewise for param "insn". > > * reload1.c (reg_reloaded_insn): Likewise for the elements of this > array. > (spill_reg_store): Likewise for the elements of this array. > (remove_init_insns): Likewise for local "equiv_insn". > (will_delete_init_insn_p): Likewise for param "insn". > (reload): Likewise for param ""first" and local "insn". > (calculate_needs_all_insns): Strengthen local "insn" from rtx to > rtx_insn *. > (calculate_elim_costs_all_insns): Likewise. > (delete_caller_save_insns): Likewise. > (spill_failure): Likewise for param "insn". > (delete_dead_insn): Likewise. > (set_label_offsets): Likewise. > (eliminate_regs_in_insn): Likewise, also for locals "base_insn" and > "prev_insn". > (elimination_costs_in_insn): Likewise for param "insn". > (set_initial_eh_label_offset): Replace use of NULL_RTX with NULL > when referring to an insn. > (set_initial_label_offsets): Likewise. > (set_offsets_for_label): Strengthen param "insn" from rtx to > rtx_insn *. > (init_eliminable_invariants): Likewise for param "first" and local > "insn". > (fixup_eh_region_note): Likewise for param "insn". > (reload_as_needed): Likewise for locals "prev", "insn", > "old_next", "old_prev", "next". > (gen_reload_chain_without_interm_reg_p): Likewise for locals "insn", > "last". > (reload_inheritance_insn): Strengthen elements of this array from > rtx to rtx_insn *. > (failed_reload): Likewise for param "insn". > (choose_reload_regs): Likewise for local "insn". Replace use of > NULL_RTX with NULL when referring to an insn. > (input_reload_insns): Strengthen elements of this array from rtx > to rtx_insn *. > (other_input_address_reload_insns): Likewise for this global. > (other_input_reload_insns): Likewise for this global. > (input_address_reload_insns): Likwise for the elements of this > array. > (inpaddr_address_reload_insns): Likwise for the elements of this > array. > (output_reload_insns): Likewise for the elements of this array. > (output_address_reload_insns): Likewise for the elements of this > array. > (outaddr_address_reload_insns): Likewise for the elements of this > array. > (operand_reload_insns): Likewise for this global. > (other_operand_reload_insns): Likewise for this global. > (other_output_reload_insns): Likewise for the elements of this > array. > (new_spill_reg_store): Likewise for the elements of this > array. > (emit_input_reload_insns): Likewise for locals "insn", "temp". > Strengthen local "where" from rtx * to rtx_insn **. > (emit_output_reload_insns): Strengthen locals "insn", "p", "next" > from rtx to rtx_insn *. > (do_input_reload): Likewise for local "insn". > (do_output_reload): Likewise for local "insn". > (emit_reload_insns): Likewise for locals "insn" and "store_insn". > (emit_insn_if_valid_for_reload): Likewise for return type and local > "last". Add checked cast to rtx_insn when returning "insn" since > this has been through emit_insn. > (gen_reload): Strengthen return type and locals "last", "insn", "set" > from rtx to rtx_insn *. Add checked cast to rtx_insn when > returning "insn" since it's been through > emit_insn_if_valid_for_reload at this point. > (delete_output_reload): Strengthen param "insn" and locals > "output_reload_insn", "i2" from rtx to rtx_insn *. > (delete_address_reloads): Likewise for params "dead_insn", > "current_insn" and locals "prev", "next". > (delete_address_reloads_1): Likewise for params "dead_insn", > "current_insn" and locals "prev", "i2". > (inc_for_reload): Likewise for locals "last", "add_insn". > (add_auto_inc_notes): Strengthen param "insn" from rtx to > rtx_insn *. > > * config/arc/arc-protos.h (regno_clobbered_p): Likewise for 2nd > param of this duplicate of the prototype from reload.h OK. jeff