public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <burnus@net-b.de>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>,
	"Gcc Patch List" <gcc-patches@gcc.gnu.org>,
	"fortran@gcc.gnu.org List" <fortran@gcc.gnu.org>,
	"Dodji Seketeli" <dodji@redhat.com>
Subject: Re: [PATCH Fortran/Diagnostics] Move Fortran to common diagnostics machinery
Date: Fri, 15 Aug 2014 13:29:00 -0000	[thread overview]
Message-ID: <53EE0B27.70706@net-b.de> (raw)
In-Reply-To: <CAESRpQAAg8r10Eqw5G-0zXSp=DRv67Rv1KfxpnuQu6A0oiyNNQ@mail.gmail.com>

Am 06.08.2014 18:50, schrieb Manuel López-Ibáñez:
> This is the first step for moving Fortran to use the common
> diagnostics machinery. This patch makes Fortran use the common
> machinery for those warnings that don't have a location or a
> controlling option.
> Bootstrapped and regression tested on x86_64-linux-gnu.
> OK?

Sorry for replying belated, I was in vacation and seemingly, a few 
others as well.

The patch looks good to me, except for gfc-diagnostic.def which contains 
the file content twice. With that fixed, the patch is OK. Thanks a lot!

Tobias

> 2014-08-03  Manuel López-Ibáñez  <manu@gcc.gnu.org>
>
>      PR fortran/44054
> c-family/
>      * c-format.c: Handle Fortran flags.
>      * diagnostic.c (build_message_string): Make it extern.
>      * diagnostic.h (build_message_string): Make it extern.
> fortran/
>      * gfortran.h: Define GCC_DIAG_STYLE.
>      (gfc_diagnostics_init,gfc_warning_cmdline): Declare.
>      * trans-array.c: Include gfortran.h before diagnostic-core.h.
>      * trans-expr.c: Likewise.
>      * trans-openmp.c: Likewise.
>      * trans-const.c: Likewise.
>      * trans.c: Likewise.
>      * trans-types.c: Likewise.
>      * f95-lang.c: Likewise.
>      * trans-decl.c: Likewise.
>      * trans-io.c: Likewise.
>      * trans-intrinsic.c: Likewise.
>      * error.c: Include diagnostic.h and diagnostic-color.h.
>      (gfc_diagnostic_build_prefix): New.
>      (gfc_diagnostic_starter): New.
>      (gfc_diagnostic_finalizer): New.
>      (gfc_warning_cmdline): New.
>      (gfc_diagnostics_init): New.
>      * gfc-diagnostic.def: New.
>      * options.c (gfc_init_options): Call gfc_diagnostics_init.
>      (gfc_post_options): Use gfc_warning_cmdline.

      parent reply	other threads:[~2014-08-15 13:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06 16:51 Manuel López-Ibáñez
2014-08-08 10:25 ` Dodji Seketeli
2014-08-14 20:10   ` Manuel López-Ibáñez
2014-08-15 13:29 ` Tobias Burnus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EE0B27.70706@net-b.de \
    --to=burnus@net-b.de \
    --cc=dodji@redhat.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=lopezibanez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).