From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12939 invoked by alias); 17 Aug 2014 13:06:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12917 invoked by uid 89); 17 Aug 2014 13:06:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp22.services.sfr.fr Received: from smtp22.services.sfr.fr (HELO smtp22.services.sfr.fr) (93.17.128.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Aug 2014 13:06:00 +0000 Received: from filter.sfr.fr (localhost [79.94.5.212]) by msfrf2212.sfr.fr (SMTP Server) with ESMTP id B32D370000FD; Sun, 17 Aug 2014 15:05:57 +0200 (CEST) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=mikael.morin@sfr.fr Received: from [192.168.2.95] (212.5.94.79.rev.sfr.net [79.94.5.212]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by msfrf2212.sfr.fr (SMTP Server) with ESMTP id CBAED70000F7; Sun, 17 Aug 2014 15:05:56 +0200 (CEST) X-SFR-UUID: 20140817130556834.CBAED70000F7@msfrf2212.sfr.fr Message-ID: <53F0A8BA.2000303@sfr.fr> Date: Sun, 17 Aug 2014 13:06:00 -0000 From: Mikael Morin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Dominique Dhumieres , vehre@gmx.de, fortran@gcc.gnu.org CC: gcc-patches@gcc.gnu.org, fxcoudert@gmail.com Subject: Re: [PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal References: <20140721072605.0D680105@mailhost.lps.ens.fr> <20140721150350.10b35dd3@vepi2.private> <911AF20A-F5E2-474F-858A-BF5CE56235D5@lps.ens.fr> <53D3FF8A.106@sfr.fr> <20140806212302.4bf07e11@vepi2.private> <53F09518.8040601@sfr.fr> <20140817122628.2773C105@mailhost.lps.ens.fr> In-Reply-To: <20140817122628.2773C105@mailhost.lps.ens.fr> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01692.txt.bz2 Le 17/08/2014 14:26, Dominique Dhumieres a écrit : > As Mikael said in https://gcc.gnu.org/ml/fortran/2014-08/msg00047.html > >> the testcase should check that the code generated is actually working, >> not just that the ICE disappeared. ... > Well, this is for another patch where deferred character variable are made acceptable as argument to unlimited polymorphic dummies. Here the ICE comes (if I remember correctly) from the wrong generic procedure being picked, so there is not really some new feature enabled with the patch. > thus I think the test should be run, i.e., '! { dg-do compile }' should > be replaced with '! { dg-do run }' (I have checked that the test succeeds). > I don't have a strong opinion for it, but I'm OK with that change. In fact the initial test was a run one, and it has been changed to compile. Andre: why? Mikael