From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19234 invoked by alias); 20 Aug 2014 21:42:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19224 invoked by uid 89); 20 Aug 2014 21:42:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_INFOUSME autolearn=no version=3.3.2 X-HELO: batou.ecranbleu.org Received: from batou.ecranbleu.org (HELO batou.ecranbleu.org) (195.154.220.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Aug 2014 21:42:22 +0000 Received: by batou.ecranbleu.org (Postfix, from userid 999) id B4454120677; Wed, 20 Aug 2014 23:42:22 +0200 (CEST) Received: from [192.168.12.5] (unknown [192.168.12.5]) (Authenticated sender: sylvestredeb@ledru.info) by batou.ecranbleu.org (Postfix) with ESMTPSA id CBF3512010D; Wed, 20 Aug 2014 23:42:20 +0200 (CEST) Message-ID: <53F51639.5010908@debian.org> Date: Wed, 20 Aug 2014 21:42:00 -0000 From: Sylvestre Ledru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: "Joseph S. Myers" CC: =?windows-1252?Q?Manuel_L=F3pez-Ib=E1=F1ez?= , Gcc Patch List , Jason Merrill Subject: Re: [Patch] PR55189 enable -Wreturn-type by default References: <53EE3537.1000000@debian.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg02067.txt.bz2 On 20/08/2014 00:02, Joseph S. Myers wrote: > On Fri, 15 Aug 2014, Sylvestre Ledru wrote: > >> It is indeed useless. I removed it. Thanks >> http://sylvestre.ledru.info/0001-Enable-warning-Wreturn-type-by-default.patch > I don't think most of the testsuite changes in this patch should be > needed, and we should be conservative about changing existing testcases > because of the risk that it affects what they test. Most of the changes > seem like they would only have been relevant for the previous version that > enabled -Wmissing-return warnings by default. > > The change to gcc.dg/c90-impl-int-1.c is simply wrong - the specific point > of that testcase is to test various cases of implicit int, so you can't > add explicit int return types to it. > > You need, obviously, the new tests for how -W(no-)missing-return and > -W(no-)return-type work and what the defaults are. Existing tests should > only need to be changed if they do in fact fail with the compiler patch > applied. > Thanks for the feedback. I updated the patch (including the gcc.dg/c90-impl-int-1.c change): http://sylvestre.ledru.info/0001-Enable-warning-Wreturn-type-by-default.patch For information, the number of files modified by this commit dropped from 1298 to 818. Thanks, Sylvestre