From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ RFC/Patch] PR 34938
Date: Fri, 22 Aug 2014 19:27:00 -0000 [thread overview]
Message-ID: <53F79990.5040004@redhat.com> (raw)
In-Reply-To: <53F797AD.5070309@oracle.com>
On 08/22/2014 03:19 PM, Paolo Carlini wrote:
> Ok. Currently in cases like the present one, dump_type_suffix upon a
> pointer recurses and we end up calling pp_cxx_cv_qualifiers on the given
> FUNCTION_TYPE / METHOD_TYPE. Thus pp_cxx_cv_qualifiers lacks the pointer
> context, just sees the latter. Do you think that the current simple
> setup, thus my patch which just extends it, can be incorrect in some cases?
Yes, I think your patch changes it to be incorrect in different cases
than the ones where it's currently incorrect, namely the typedef and
template argument cases that I mentioned.
Incidentally, I don't understand
> + pp_c_ws_string (pp, (func_type && !method_type
vs
> + pp_c_ws_string (pp, (func_type || method_type
Surely the same logic is appropriate for both const and noreturn, and
they are represented the same way on both function_ and method_type.
Jason
next prev parent reply other threads:[~2014-08-22 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 17:53 Paolo Carlini
2014-08-22 18:17 ` Jason Merrill
2014-08-22 19:19 ` Paolo Carlini
2014-08-22 19:27 ` Jason Merrill [this message]
2014-08-22 19:33 ` Paolo Carlini
2014-08-22 19:48 ` Manuel López-Ibáñez
2014-08-22 19:56 ` Jason Merrill
2014-08-22 20:35 ` Paolo Carlini
2014-08-22 20:45 ` Jason Merrill
2014-08-22 21:16 ` Paolo Carlini
2014-08-23 7:16 ` Paolo Carlini
2014-08-23 15:03 ` Paolo Carlini
2014-08-25 2:53 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F79990.5040004@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).