* [PATCH] Small fix for r214086 Asan regression
@ 2014-08-26 6:35 Yury Gribov
2014-08-27 20:42 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Yury Gribov @ 2014-08-26 6:35 UTC (permalink / raw)
To: GCC Patches; +Cc: Jakub Jelinek, Dominique Dhumieres
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
Hi all,
Deja pattern in r214086's test is too strict (Asan runtime will not
always be able to detect that invalid memory access is
use-after-poison). I've cooked a trivial patch to loosen the check so
test now also works on i386.
Tested on x64 and i386. Ok to commit?
-Y
[-- Attachment #2: pr62089-fix-1.diff --]
[-- Type: text/x-diff, Size: 667 bytes --]
commit aa3258be3749174a407185835a0484ebcbaf9bd3
Author: Yury Gribov <y.gribov@samsung.com>
Date: Mon Aug 25 12:04:01 2014 +0400
2014-08-26 Yury Gribov <y.gribov@samsung.com>
* c-c++-common/asan/pr62089.c: Fix test on 32-bit platforms.
diff --git a/gcc/testsuite/c-c++-common/asan/pr62089.c b/gcc/testsuite/c-c++-common/asan/pr62089.c
index 22b877b..b436b41 100644
--- a/gcc/testsuite/c-c++-common/asan/pr62089.c
+++ b/gcc/testsuite/c-c++-common/asan/pr62089.c
@@ -34,4 +34,4 @@ main () {
return 0;
}
-/* { dg-output "ERROR: AddressSanitizer: use-after-poison" } */
+/* { dg-output "ERROR: AddressSanitizer:\[^\n\r]*on address\[^\n\r]*" } */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Small fix for r214086 Asan regression
2014-08-26 6:35 [PATCH] Small fix for r214086 Asan regression Yury Gribov
@ 2014-08-27 20:42 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2014-08-27 20:42 UTC (permalink / raw)
To: Yury Gribov, GCC Patches; +Cc: Jakub Jelinek, Dominique Dhumieres
On 08/26/14 00:35, Yury Gribov wrote:
> Hi all,
>
> Deja pattern in r214086's test is too strict (Asan runtime will not
> always be able to detect that invalid memory access is
> use-after-poison). I've cooked a trivial patch to loosen the check so
> test now also works on i386.
>
> Tested on x64 and i386. Ok to commit?
OK.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-27 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-26 6:35 [PATCH] Small fix for r214086 Asan regression Yury Gribov
2014-08-27 20:42 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).