From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-376406-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 20044 invoked by alias); 29 Aug 2014 01:02:26 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 20031 invoked by uid 89); 29 Aug 2014 01:02:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 Aug 2014 01:02:24 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7T12MsI019825	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Thu, 28 Aug 2014 21:02:23 -0400
Received: from pike.twiddle.home (vpn-49-214.rdu2.redhat.com [10.10.49.214])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7T12LWK019237;	Thu, 28 Aug 2014 21:02:21 -0400
Message-ID: <53FFD11B.9010708@redhat.com>
Date: Fri, 29 Aug 2014 01:02:00 -0000
From: Richard Henderson <rth@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0
MIME-Version: 1.0
To: David Malcolm <dmalcolm@redhat.com>, "H.J. Lu" <hjl.tools@gmail.com>
CC: Jeff Law <law@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params
References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com>		<1407345815-14551-226-git-send-email-dmalcolm@redhat.com>		<53F3BA30.4050301@redhat.com>	<1408484146.2473.128.camel@surprise>		<53FB4743.5030103@redhat.com>	<1409073313.24896.42.camel@surprise>	 <CAMe9rOqCt0o3wj3QoLQg3Mp-fYL0-=10Ah5C-==UwDc0FtDRag@mail.gmail.com> <1409273237.31600.5.camel@surprise>
In-Reply-To: <1409273237.31600.5.camel@surprise>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2014-08/txt/msg02615.txt.bz2

On 08/28/2014 05:47 PM, David Malcolm wrote:
> -	  insn = as_a <rtx_insn *> (
> -		   gen_extend_insn (op0, t, promoted_nominal_mode,
> -				    data->passed_mode, unsignedp));
> -	  emit_insn (insn);
> +	  rtx pat = gen_extend_insn (op0, t, promoted_nominal_mode,
> +				     data->passed_mode, unsignedp);
> +	  emit_insn (pat);

Certainly ok.


r~