From: Michael Eager <eager@eagercon.com>
To: Neal Frager <neal.frager@amd.com>,
gcc-patches@gcc.gnu.org, eager@eagerm.com
Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com,
mark.hatle@amd.com, sadanand.mutyala@amd.com,
appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com,
luca.ceresoli@bootlin.com
Subject: Re: [PATCH v3 1/1] gcc: config: microblaze: fix cpu version check
Date: Thu, 26 Oct 2023 12:44:54 -0700 [thread overview]
Message-ID: <53b9453d-ec5c-4971-a675-2d160eaf7b81@eagercon.com> (raw)
In-Reply-To: <20231025080201.2367290-1-neal.frager@amd.com>
On 10/25/23 01:02, Neal Frager wrote:
> The MICROBLAZE_VERSION_COMPARE was incorrectly using strcasecmp
> instead of strverscmp to check the mcpu version against feature
> options. By simply changing the define to use strverscmp,
> the new version 10.0 is treated correctly as a higher version
> than previous versions.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> V1->V2:
> - No need to create a new microblaze specific version check
> routine as strverscmp is the correct solution.
> V2->V3:
> - Changed mcpu define for microblaze isa testsuite examples.
> ---
> gcc/config/microblaze/microblaze.cc | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/bshift.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/div.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/fcmp1.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/fcmp2.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/fcmp3.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/fcmp4.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/fcvt.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/float.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/fsqrt.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/mul-bshift-pcmp.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/mul-bshift.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/mul.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/mulh-bshift-pcmp.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/mulh.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/nofcmp.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/nofloat.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/pcmp.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/isa/vanilla.c | 2 +-
> gcc/testsuite/gcc.target/microblaze/microblaze.exp | 2 +-
> 20 files changed, 20 insertions(+), 20 deletions(-)
>
Only two test cases actually test this fix.
Please add a ChangeLog update for these changes.
--
Michael Eager
prev parent reply other threads:[~2023-10-26 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:02 Neal Frager
2023-10-26 19:44 ` Michael Eager [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53b9453d-ec5c-4971-a675-2d160eaf7b81@eagercon.com \
--to=eager@eagercon.com \
--cc=appa.rao.nali@amd.com \
--cc=eager@eagerm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=luca.ceresoli@bootlin.com \
--cc=mark.hatle@amd.com \
--cc=nagaraju.mekala@amd.com \
--cc=neal.frager@amd.com \
--cc=sadanand.mutyala@amd.com \
--cc=vidhumouli.hunsigida@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).