From: Tobias Burnus <tobias@codesourcery.com>
To: Mark Eggleston <mark.eggleston@codethink.co.uk>,
Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>, <gerald@pfeifer.com>
Subject: Re: [Patch, gcc-wwdocs] Update to Fortran changes
Date: Wed, 27 Nov 2019 09:03:00 -0000 [thread overview]
Message-ID: <53f9d677-8a7a-01be-5bdf-ddbeb9670dc1@codesourcery.com> (raw)
In-Reply-To: <e55c0f82-6f22-f5ce-3145-af24bade6214@codethink.co.uk>
On 11/26/19 7:33 PM, Mark Eggleston wrote:
> htdocs/gcc-10/changes.html | 41 +++++++++++++++++++++++++++++++++++++++++
>
> + <li>
> + Default fields widths can be used for <code>I</code>, <code>F</code>
> + and <code>G</code> format specifiers when excplicit widths are omitted.
> + Use the option <code>-fdec-format-defaults</code>, this options is implied
> + with <code>-fdec</code>.
> + </li>
Typo: excplicit. I had to read it twice and look at the manual: The
options permits to use I/F/G data-edit descriptors** without specifying
a number (a width) and then a default width is used. At the first
reading, I wondered whether in the code or on the command line one
specifies the default value.
Maybe the following is clearer:
"For formatted input/output, if the explicit widths after the data-edit
descriptors <code>I</code>, <code>F</code> and <code>G</code> have been
omitted, default widths are used."
Other wording suggestions are welcome.
> + <li>
> + A blank format item at the end of a format specification i.e. nothing
> + following the final comma is allowed. Use the option
> + <code>-fdec-blank-format-item</code>, this options is implied with
> + <code>-fdec</code>.
> + </li>
(I personally would add a comma before 'i.e.' and 'is allowed' â but
commas are a rather personal affair.*)
> + <li>
> + Character type names in errors and warnings now include <code>len</code>
> + in addition to <code>kind</code>, <code>*</code> is used for assumed
> + length. The kind is omitted if it the default kind. Examples:
> + <code>CHARACTER(12)</code>, <code>CHARACTER(6,4)</code>.
I'd use a semicolon instead of a comma before "* is used for". And add
an 'is' after 'if it'.
Otherwise, it looks good to me.
Tobias
*Cf. https://www.newyorker.com/magazine/2015/02/23/holy-writ
** data-edit-desc is the wording used by the Fortran standard; but I
don't think its name makes it immediately clear what is meant.
next prev parent reply other threads:[~2019-11-27 9:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 10:48 Mark Eggleston
2019-11-26 11:33 ` Tobias Burnus
2019-11-26 16:29 ` Mark Eggleston
2019-11-26 18:48 ` Mark Eggleston
2019-11-27 9:03 ` Tobias Burnus [this message]
2019-11-27 14:19 ` Mark Eggleston
2019-11-28 23:48 ` Gerald Pfeifer
2019-11-27 8:08 ` Janne Blomqvist
2019-11-27 8:29 ` Tobias Burnus
2019-11-27 8:37 ` Janne Blomqvist
2019-11-27 17:34 ` Mark Eggleston
2019-11-28 20:12 ` Making things a bit easier (was: [Patch, gcc-wwdocs] Update to Fortran changes) Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f9d677-8a7a-01be-5bdf-ddbeb9670dc1@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=mark.eggleston@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).