From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 842723858D35 for ; Wed, 28 Jun 2023 10:20:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 842723858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6279BC14; Wed, 28 Jun 2023 03:20:51 -0700 (PDT) Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E1273F663; Wed, 28 Jun 2023 03:20:07 -0700 (PDT) Message-ID: <53fc10c5-8827-fb59-3cc6-4f48c904f846@arm.com> Date: Wed, 28 Jun 2023 11:20:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Content-Language: en-GB To: Christophe Lyon , gcc-patches@gcc.gnu.org, Kyrylo.Tkachov@arm.com References: <20230628092631.3173114-1-christophe.lyon@linaro.org> From: "Richard Earnshaw (lists)" In-Reply-To: <20230628092631.3173114-1-christophe.lyon@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3498.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28/06/2023 10:26, Christophe Lyon via Gcc-patches wrote: > If GCC is configured with the default (soft) -mfloat-abi, and we don't > override the target_board test flags appropriately, > gcc.target/arm/mve/general-c/nomve_fp_1.c fails for lack of > -mfloat-abi=softfp or -mfloat-abi=hard, because it doesn't use > dg-add-options arm_v8_1m_mve (on purpose, see comment in the test). > > Require and use the options needed for arm_fp to fix this problem. > > 2023-06-28 Christophe Lyon > > gcc/testsuite/ > * gcc.target/arm/mve/general-c/nomve_fp_1.c: Require arm_fp. > --- > gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c > index 21c2af16a61..c9d279ead68 100644 > --- a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c > +++ b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c > @@ -1,9 +1,11 @@ > /* { dg-do compile } */ > /* { dg-require-effective-target arm_v8_1m_mve_ok } */ > +/* { dg-require-effective-target arm_fp_ok } */ > /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "", > which could imply mve+fp depending on the user settings. We want to make > sure the '+fp' extension is not enabled. */ > /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */ > +/* { dg-add-options arm_fp } */ > > #include > OK.