From: Jeff Law <law@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix UB in expmed.c (PR middle-end/61903)
Date: Fri, 29 Aug 2014 20:08:00 -0000 [thread overview]
Message-ID: <5400DDA4.2060505@redhat.com> (raw)
In-Reply-To: <20140825192135.GL15033@redhat.com>
On 08/25/14 13:21, Marek Polacek wrote:
> The following ought to fix two spots where an undefined behavior
> can occur when compiling pr28045.c with instrumented compiler.
> It does so by changing the type of V to an unsigned HOST_WIDE_INT
> and performing the shift on unsigned HOST_WIDE_INT.
> Hopefully it doesn't break anything...
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
>
> 2014-08-25 Marek Polacek <polacek@redhat.com>
>
> PR middle-end/61903
> * expmed.c (store_fixed_bit_field_1): Shift UHWI 1 instead of HWI 1.
> Change the type of V to unsigned HOST_WIDE_INT.
OK.
Jeff
prev parent reply other threads:[~2014-08-29 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 19:21 Marek Polacek
2014-08-29 20:08 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5400DDA4.2060505@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).