public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch] propagate INSTALL Makefile variables down from gcc/
@ 2014-08-21 15:50 Olivier Hainque
  2014-08-30  6:36 ` Jeff Law
  0 siblings, 1 reply; 3+ messages in thread
From: Olivier Hainque @ 2014-08-21 15:50 UTC (permalink / raw)
  To: gcc-patches; +Cc: Nicolas Roche

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hello,

Experiments with custom install programs exposed that the INSTALL series of
Makefile variables aren't propagated down from the gcc subdir.

This patch fixes this. Checked that it addressed the unexpected behavior we
were observing + bootstrapped & regtested on x86_64-linux-gnu.

OK to commit ?

Thanks in advance for your feedback,

With Kind Regards,

Olivier


2014-08-21  Nicolas Roche <roche@adacore.com>

        * Makefile.in (FLAGS_TO_PASS): Propagate INSTALL, INSTALL_DATA,
	INSTALL_SCRIPT and INSTALL_PROGRAM as well.

[see attached file: propagate-install.diff]

[-- Attachment #2: propagate-install.diff --]
[-- Type: application/octet-stream, Size: 428 bytes --]

diff --git gcc/Makefile.in gcc/Makefile.in
index 56f4c84..e67d176 100644
--- gcc/Makefile.in
+++ gcc/Makefile.in
@@ -1096,6 +1096,10 @@ FLAGS_TO_PASS = \
 	"LDFLAGS=$(LDFLAGS)" \
 	"FLEX=$(FLEX)" \
 	"FLEXFLAGS=$(FLEXFLAGS)" \
+	"INSTALL=$(INSTALL)" \
+	"INSTALL_DATA=$(INSTALL_DATA)" \
+	"INSTALL_PROGRAM=$(INSTALL_PROGRAM)" \
+	"INSTALL_SCRIPT=$(INSTALL_SCRIPT)" \
 	"LN=$(LN)" \
 	"LN_S=$(LN_S)" \
 	"MAKEINFO=$(MAKEINFO)" \

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] propagate INSTALL Makefile variables down from gcc/
  2014-08-21 15:50 [patch] propagate INSTALL Makefile variables down from gcc/ Olivier Hainque
@ 2014-08-30  6:36 ` Jeff Law
  2014-09-01  8:44   ` Olivier Hainque
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2014-08-30  6:36 UTC (permalink / raw)
  To: Olivier Hainque, gcc-patches; +Cc: Nicolas Roche

On 08/21/14 09:49, Olivier Hainque wrote:
> Hello,
>
> Experiments with custom install programs exposed that the INSTALL series of
> Makefile variables aren't propagated down from the gcc subdir.
>
> This patch fixes this. Checked that it addressed the unexpected behavior we
> were observing + bootstrapped & regtested on x86_64-linux-gnu.
>
> OK to commit ?
>
> Thanks in advance for your feedback,
>
> With Kind Regards,
>
> Olivier
>
>
> 2014-08-21  Nicolas Roche <roche@adacore.com>
>
>          * Makefile.in (FLAGS_TO_PASS): Propagate INSTALL, INSTALL_DATA,
> 	INSTALL_SCRIPT and INSTALL_PROGRAM as well.
OK.
Jeff

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] propagate INSTALL Makefile variables down from gcc/
  2014-08-30  6:36 ` Jeff Law
@ 2014-09-01  8:44   ` Olivier Hainque
  0 siblings, 0 replies; 3+ messages in thread
From: Olivier Hainque @ 2014-09-01  8:44 UTC (permalink / raw)
  To: Jeff Law; +Cc: gcc-patches, Nicolas Roche


On Aug 30, 2014, at 8:36 AM, Jeff Law wrote:
>>         * Makefile.in (FLAGS_TO_PASS): Propagate INSTALL, INSTALL_DATA,
>> 	INSTALL_SCRIPT and INSTALL_PROGRAM as well.
> OK.

Checked-in, Thanks :)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-01  8:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-21 15:50 [patch] propagate INSTALL Makefile variables down from gcc/ Olivier Hainque
2014-08-30  6:36 ` Jeff Law
2014-09-01  8:44   ` Olivier Hainque

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).