From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11688 invoked by alias); 5 Sep 2014 02:25:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11676 invoked by uid 89); 5 Sep 2014 02:25:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 05 Sep 2014 02:25:15 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s852PEGP007321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 4 Sep 2014 22:25:14 -0400 Received: from stumpy.slc.redhat.com ([10.3.113.7]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s852PDj2030653; Thu, 4 Sep 2014 22:25:13 -0400 Message-ID: <54091F09.1020104@redhat.com> Date: Fri, 05 Sep 2014 02:25:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 02/10] Drop uncast_insn from param 1 of final_scan_insn References: <1409881927-61672-1-git-send-email-dmalcolm@redhat.com> <1409881927-61672-3-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1409881927-61672-3-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00428.txt.bz2 On 09/04/14 19:51, David Malcolm wrote: > gcc/ > > * output.h (final_scan_insn): Strengthen first param from rtx to > rtx_insn *. > > * final.c (final_scan_insn): Likewise, renaming it back from > "uncast_insn" to "insn", eliminating the checked cast. > > * config/h8300/h8300.md (define_insn "jump"): Replace local rtx > "vec" with an rtx_sequence * "seq", taking a copy of > "final_sequence", and using methods of "seq" for clarity, and for > type-safety in the calls to final_scan_insn. > * config/mips/mips.c (mips_output_conditional_branch): Use methods > of "final_sequence" for clarity, and for type-safety in the call to > final_scan_insn. > * config/sh/sh.c (print_slot): Strengthen param from rtx to > rtx_sequence * and rename from "insn" to "seq". OK. Jeff