From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24227 invoked by alias); 5 Sep 2014 18:32:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24210 invoked by uid 89); 5 Sep 2014 18:32:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 05 Sep 2014 18:32:50 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s85IWYdR014035 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Sep 2014 14:32:34 -0400 Received: from stumpy.slc.redhat.com ([10.3.113.7]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s85IWX9g002254; Fri, 5 Sep 2014 14:32:34 -0400 Message-ID: <540A01C1.8030700@redhat.com> Date: Fri, 05 Sep 2014 18:32:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Jakub Jelinek , David Malcolm CC: Andi Kleen , gcc-patches@gcc.gnu.org, Andi Kleen Subject: Re: [PATCH] Add XINSN macro and use it within NEXT_INSN/PREV_INSN (was Re: [PATCH] Force rtl templates to be inlined) References: <1409641427-29875-1-git-send-email-andi@firstfloor.org> <1409669743.19403.13.camel@surprise> <20140902175037.GA4120@two.firstfloor.org> <1409861057.19403.19.camel@surprise> <20140904202215.GG17454@tucnak.redhat.com> In-Reply-To: <20140904202215.GG17454@tucnak.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00524.txt.bz2 On 09/04/14 14:22, Jakub Jelinek wrote: > On Thu, Sep 04, 2014 at 04:04:17PM -0400, David Malcolm wrote: >> --- a/gcc/rtl.h >> +++ b/gcc/rtl.h >> @@ -195,6 +195,7 @@ union rtunion >> unsigned int rt_uint; >> const char *rt_str; >> rtx rt_rtx; >> + rtx_insn *rt_insn; >> rtvec rt_rtvec; >> enum machine_mode rt_type; >> addr_diff_vec_flags rt_addr_diff_vec_flags; >> @@ -1208,6 +1209,7 @@ extern void rtl_check_failed_flag (const char *, const_rtx, const char *, >> #define XUINT(RTX, N) (RTL_CHECK2 (RTX, N, 'i', 'n').rt_uint) >> #define XSTR(RTX, N) (RTL_CHECK2 (RTX, N, 's', 'S').rt_str) >> #define XEXP(RTX, N) (RTL_CHECK2 (RTX, N, 'e', 'u').rt_rtx) > > Shouldn't XEXP be changed into RTL_CHECK1 (RTX, N, 'e').rt_rtx > then and the accessors of first operand of INSN_LIST and only operand of > LABEL_REF be changed to XINSN too? Of course doesn't have to be done > immediately, can be done as a followup. Yea, let's chase this as a follow-up. Jeff