From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12930 invoked by alias); 12 Sep 2014 17:56:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12918 invoked by uid 89); 12 Sep 2014 17:56:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Sep 2014 17:56:10 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8CHu8Fr023439 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Sep 2014 13:56:08 -0400 Received: from [10.10.116.16] ([10.10.116.16]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8CHu74U022779; Fri, 12 Sep 2014 13:56:08 -0400 Message-ID: <541333B4.3090000@redhat.com> Date: Fri, 12 Sep 2014 17:56:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Aldy Hernandez , Richard Biener CC: gcc-patches Subject: Re: [debug-early] reuse variable DIEs and fix their context References: <53FD45A7.4000804@redhat.com> <53FF6840.9030505@redhat.com> <53FF6E61.6030507@redhat.com> <540755E5.7060602@redhat.com> <5409220E.6070100@redhat.com> <540E4337.70006@redhat.com> <5412438A.6030305@redhat.com> <54130E15.9030809@redhat.com> <5413291A.7050209@redhat.com> <54132E6E.1060806@redhat.com> <541331D2.8080602@redhat.com> In-Reply-To: <541331D2.8080602@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg01079.txt.bz2 On 09/12/2014 01:48 PM, Aldy Hernandez wrote: > Unless I'm misunderstanding something, validate_phases() verifies that > the numbers add up by looking at the actual string name of the phase, > irregardless of if you timevar_push/pop'ed it: Yes, but why wouldn't the numbers add up? The comment for timevar_push_1 says "No further elapsed time is attributed to the previous topmost timing variable on the stack; subsequent elapsed time is attributed to TIMEVAR, until it is popped or another element is pushed on top." Jason