From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-377690-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 23851 invoked by alias); 15 Sep 2014 09:46:49 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 23841 invoked by uid 89); 15 Sep 2014 09:46:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: service87.mimecast.com
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Sep 2014 09:46:47 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 15 Sep 2014 10:46:43 +0100
Received: from e105689-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Mon, 15 Sep 2014 10:46:41 +0100
Message-ID: <5416B580.9070208@arm.com>
Date: Mon, 15 Sep 2014 09:46:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
MIME-Version: 1.0
To: Andrew Stubbs <ams@codesourcery.com>,  "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [arm][patch] fix arm_neon_ok check on !arm_arch7
References: <5414B99D.3020202@codesourcery.com>
In-Reply-To: <5414B99D.3020202@codesourcery.com>
X-MC-Unique: 114091510464304901
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg01171.txt.bz2

On 13/09/14 22:39, Andrew Stubbs wrote:
> Hi,
>=20
> I get a lot of "vect/*" and "neon-*" test failure in my armv5te testing=20
> because the arm_neon_ok test incorrectly detects that NEON is valid on=20
> arm926ej-s.
>=20
> It turns out that the reason is that the compiler only disallows NEON=20
> for Thumb1 or soft-float configurations. Otherwise it just takes=20
> -mfpu=3Dneon at face value, regardless of -march or -mcpu.
>=20
> This patch limits NEON to armv7 or higher.
>=20
> OK?
>=20
> Andrew
>=20
>=20
> arm_neon_ok.patch
>=20
>=20
> 2014-09-13  Andrew Stubbs  <ams@codesourcery.com>
>=20
> 	gcc/
> 	* config/arm/arm.h (TARGET_NEON): Ensure target is v7 or higher.
>=20
> Index: gcc/config/arm/arm.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- gcc/config/arm/arm.h	(revision 215228)
> +++ gcc/config/arm/arm.h	(working copy)
> @@ -323,6 +323,7 @@
>     and TARGET_HARD_FLOAT to ensure that NEON instructions are
>     available.  */
>  #define TARGET_NEON (TARGET_32BIT && TARGET_HARD_FLOAT \
> +		     && arm_arch7 \
>  		     && TARGET_VFP && arm_fpu_desc->neon)
>=20=20
>  /* Q-bit is present.  */
>=20


Hmm, I wonder if arm_override_options should reject neon + (arch < 7).

R.