public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Earnshaw <rearnsha@arm.com>
To: Andrew Stubbs <ams@codesourcery.com>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [arm][patch] fix arm_neon_ok check on !arm_arch7
Date: Mon, 15 Sep 2014 13:30:00 -0000	[thread overview]
Message-ID: <5416E9CF.1030101@arm.com> (raw)
In-Reply-To: <5416C5C3.8070603@codesourcery.com>

On 15/09/14 11:56, Andrew Stubbs wrote:
> On 15/09/14 10:46, Richard Earnshaw wrote:
>> Hmm, I wonder if arm_override_options should reject neon + (arch < 7).
> 
> Is this more to your taste?
> 

Yep, that's fine.

> Andrew
> 
> P.S. arm_override_options was renamed in 2010.

I'm getting old :-(

R.

> 
> 
> arm_neon_ok-2.patch
> 
> 
> 2014-09-15  Andrew Stubbs  <ams@codesourcery.com>
> 
> 	* gcc/config/arm/arm.c (arm_option_override): Reject -mfpu=neon
> 	when architecture is older than ARMv7.
> 
> Index: gcc/config/arm/arm.c
> ===================================================================
> --- gcc/config/arm/arm.c	(revision 215228)
> +++ gcc/config/arm/arm.c	(working copy)
> @@ -2845,6 +2845,9 @@
>  
>    arm_fpu_desc = &all_fpus[arm_fpu_index];
>  
> +  if (TARGET_NEON && !arm_arch7)
> +    error ("target CPU does not support NEON");
> +
>    switch (arm_fpu_desc->model)
>      {
>      case ARM_FP_MODEL_VFP:
> 


  reply	other threads:[~2014-09-15 13:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-13 21:39 Andrew Stubbs
2014-09-15  9:46 ` Richard Earnshaw
2014-09-15 10:56   ` Andrew Stubbs
2014-09-15 13:30     ` Richard Earnshaw [this message]
2014-09-17 11:00       ` Andrew Stubbs
2014-09-23  8:27     ` James Greenhalgh
2014-09-23 15:22       ` Stubbs, Andrew
2014-10-15 16:37         ` Jiong Wang
2014-10-15 16:59           ` Andrew Stubbs
2014-10-16 13:53             ` Jiong Wang
2014-11-07 10:35               ` Andrew Stubbs
2014-11-14 11:17                 ` Andrew Stubbs
2014-11-26 13:11                   ` Andrew Stubbs
2014-11-27 17:28                     ` Mike Stump
2014-11-27 19:29                       ` Andrew Stubbs
2014-11-28  8:42                         ` Mike Stump
2014-12-02 14:01       ` Kyrill Tkachov
2014-12-02 21:45         ` Ramana Radhakrishnan
2014-12-03 15:03           ` Andrew Stubbs
2014-12-23 17:32             ` Andrew Stubbs
2015-01-12 14:14               ` Andrew Stubbs
2015-01-12 14:27                 ` Ramana Radhakrishnan
2015-01-13 21:08                   ` Andrew Stubbs
2015-01-14  9:06                     ` Ramana Radhakrishnan
2015-01-14 15:25                       ` Andrew Stubbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5416E9CF.1030101@arm.com \
    --to=rearnsha@arm.com \
    --cc=ams@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).