From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-377704-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 13100 invoked by alias); 15 Sep 2014 13:30:00 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 13084 invoked by uid 89); 15 Sep 2014 13:29:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: service87.mimecast.com
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Sep 2014 13:29:57 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 15 Sep 2014 14:29:54 +0100
Received: from e105689-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Mon, 15 Sep 2014 14:29:52 +0100
Message-ID: <5416E9CF.1030101@arm.com>
Date: Mon, 15 Sep 2014 13:30:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
MIME-Version: 1.0
To: Andrew Stubbs <ams@codesourcery.com>,  "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [arm][patch] fix arm_neon_ok check on !arm_arch7
References: <5414B99D.3020202@codesourcery.com> <5416B580.9070208@arm.com> <5416C5C3.8070603@codesourcery.com>
In-Reply-To: <5416C5C3.8070603@codesourcery.com>
X-MC-Unique: 114091514295400501
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg01185.txt.bz2

On 15/09/14 11:56, Andrew Stubbs wrote:
> On 15/09/14 10:46, Richard Earnshaw wrote:
>> Hmm, I wonder if arm_override_options should reject neon + (arch < 7).
>=20
> Is this more to your taste?
>=20

Yep, that's fine.

> Andrew
>=20
> P.S. arm_override_options was renamed in 2010.

I'm getting old :-(

R.

>=20
>=20
> arm_neon_ok-2.patch
>=20
>=20
> 2014-09-15  Andrew Stubbs  <ams@codesourcery.com>
>=20
> 	* gcc/config/arm/arm.c (arm_option_override): Reject -mfpu=3Dneon
> 	when architecture is older than ARMv7.
>=20
> Index: gcc/config/arm/arm.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- gcc/config/arm/arm.c	(revision 215228)
> +++ gcc/config/arm/arm.c	(working copy)
> @@ -2845,6 +2845,9 @@
>=20=20
>    arm_fpu_desc =3D &all_fpus[arm_fpu_index];
>=20=20
> +  if (TARGET_NEON && !arm_arch7)
> +    error ("target CPU does not support NEON");
> +
>    switch (arm_fpu_desc->model)
>      {
>      case ARM_FP_MODEL_VFP:
>=20