From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27940 invoked by alias); 16 Sep 2014 21:23:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27922 invoked by uid 89); 16 Sep 2014 21:23:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 16 Sep 2014 21:23:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8GLNgut022356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 Sep 2014 17:23:42 -0400 Received: from [10.10.54.167] (vpn-54-167.rdu2.redhat.com [10.10.54.167]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8GLNfdH001509; Tue, 16 Sep 2014 17:23:42 -0400 Message-ID: <5418AA5D.2090602@redhat.com> Date: Tue, 16 Sep 2014 21:23:00 -0000 From: Andrew MacLeod User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "Joseph S. Myers" CC: gcc-patches Subject: Re: Flatten function.h References: <54188D7E.4090701@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg01318.txt.bz2 On 09/16/2014 05:12 PM, Joseph S. Myers wrote: > On Tue, 16 Sep 2014, Andrew MacLeod wrote: > >> I did an include file reduction on all the language/*.[ch] and core *.[ch] >> files, but left the target files with the full complement of 7 includes that >> function.h use to have. Its probably easier when this is all done to fully >> reduce the targets one at a time... there are so many nooks and crannies I >> figured I'd bust something right now if i tried to do all the targets as well >> :-) > How did you determine what includes to remove? You appear to have removed > tm.h includes from various files that do in fact use target macros; maybe > they get it indirectly included by some other header, but I thought a > principle of this flattening was to avoid relying on such indirect > inclusions. Because of possible use of target macros in #ifdef > conditionals, "compiles with the include removed" is not a sufficient > condition for removing it. > > cfgrtl.c > gimple-fold.c > mode-switching.c > tree-inline.c > vmsdbgout.c > fortran/f95-lang.c > fortran/trans-decl.c > objc/objc-act.c > Many of those files do in fact get numerous include files from expr.h, which are likely to get put back in when expr.h is flattened, but there is a risk as you point out. Perhaps I should proceed by simply moving the includes and removing any duplicate includes, leaving the reduction for later date. There is less chance of that causing issues. I did forget about the discussion last year concerning target macros from the RTL end of things... My mind is slowly going :-). Andrew