From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24524 invoked by alias); 17 Sep 2014 20:42:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24512 invoked by uid 89); 17 Sep 2014 20:42:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Sep 2014 20:42:31 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8HKgT7t013866 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 17 Sep 2014 16:42:29 -0400 Received: from [10.10.116.27] ([10.10.116.27]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8HKgNwP014254; Wed, 17 Sep 2014 16:42:28 -0400 Message-ID: <5419F22C.2060008@redhat.com> Date: Wed, 17 Sep 2014 20:42:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Jakub Jelinek CC: Marek Polacek , gcc-patches@gcc.gnu.org Subject: Re: [RFC PATCH] -fsanitize=vptr instrumentation References: <20140916145644.GZ17454@tucnak.redhat.com> <54199A36.1080604@redhat.com> <20140917154018.GL17454@tucnak.redhat.com> <5419CCA7.4090608@redhat.com> In-Reply-To: <5419CCA7.4090608@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg01420.txt.bz2 On 09/17/2014 02:02 PM, Jason Merrill wrote: > On 09/17/2014 11:40 AM, Jakub Jelinek wrote: >> And for the last one, should we before dynamic_cast verify the object >> passed to dynamic_cast has the expected vptr? > Perhaps we should just add checking to the dynamic_cast code. I'm not > sure if that would slow it down enough to merit a separate entry point > for checking. There is some checking I want to do in dynamic_cast, but I think we also want to verify that the argument has the type expected. Jason