From: Alan Lawrence <alan.lawrence@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH 13/14][AArch64_be] Fix vec_shr pattern to correctly implement endianness-neutral optab
Date: Thu, 18 Sep 2014 12:45:00 -0000 [thread overview]
Message-ID: <541AD3E4.2030200@arm.com> (raw)
In-Reply-To: <541AC4D2.9040901@arm.com>
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
The previous patch broke aarch64_be by redefining VEC_RSHIFT_EXPR /
vec_shr_optab to always shift the vector towards gcc's element 0. This fixes
aarch64_be to do that.
check-gcc on aarch64-none-elf (no changes) and aarch64_be-none-elf (fixes all
regressions produced by previous patch, i.e. no regressions from before
redefining vec_shr).
gcc/ChangeLog:
* config/aarch64/aarch64-simd.md (vec_shr_<mode> *2): Fix bigendian.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 13_aarch64_vec_shr_neutral.patch --]
[-- Type: text/x-patch; name=13_aarch64_vec_shr_neutral.patch, Size: 968 bytes --]
diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
index 3fcf809113d73b37a95653b8c2be432478d2bc1e..e45eddbda7528cfbb4b0953b2c9934c5408d2f6d 100644
--- a/gcc/config/aarch64/aarch64-simd.md
+++ b/gcc/config/aarch64/aarch64-simd.md
@@ -776,7 +776,12 @@
(lshiftrt:VD (match_operand:VD 1 "register_operand" "w")
(match_operand:SI 2 "immediate_operand" "i")))]
"TARGET_SIMD"
- "ushr %d0, %d1, %2"
+ {
+ if (BYTES_BIG_ENDIAN)
+ return "ushl %d0, %d1, %2";
+ else
+ return "ushr %d0, %d1, %2";
+ }
[(set_attr "type" "neon_shift_imm")]
)
@@ -804,6 +809,14 @@
DONE;
}
+ if (BYTES_BIG_ENDIAN)
+ {
+ rtx temp = operands[1];
+ operands[1] = zero_reg;
+ zero_reg = temp;
+ num_bits = 128 - num_bits;
+ }
+
emit_insn (gen_aarch64_ext<mode> (operands[0], operands[1], zero_reg,
GEN_INT (num_bits / elem_bits)));
DONE;
next prev parent reply other threads:[~2014-09-18 12:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 11:41 [PATCH 0/14+2][Vectorizer] Made reductions endianness-neutral, fixes PR/61114 Alan Lawrence
2014-09-18 11:45 ` [PATCH 1/14][AArch64] Temporarily remove aarch64_gimple_fold_builtin code for reduction operations Alan Lawrence
2014-09-24 9:41 ` Marcus Shawcroft
2014-09-18 11:51 ` [PATCH 2/14][Vectorizer] Make REDUC_xxx_EXPR tree codes produce a scalar result Alan Lawrence
2014-09-22 10:34 ` Richard Biener
2014-09-22 13:23 ` Alan Lawrence
2014-09-24 15:02 ` Alan Lawrence
2014-09-24 18:08 ` Segher Boessenkool
2014-09-25 16:07 ` Alan Lawrence
2014-09-18 11:54 ` [PATCH 3/14] Add new optabs for reducing vectors to scalars Alan Lawrence
2014-09-22 10:40 ` Richard Biener
2014-09-22 13:26 ` Alan Lawrence
2014-09-22 13:38 ` Richard Biener
2014-09-25 14:33 ` [PATCH/RFC v2 " Alan Lawrence
2014-09-25 15:31 ` Richard Biener
2014-09-25 16:12 ` Alan Lawrence
2014-09-25 19:20 ` Segher Boessenkool
2014-09-18 11:59 ` [PATCH 4/14][AArch64] Use new reduc_plus_scal optabs, inc. for __builtins Alan Lawrence
2014-09-24 9:44 ` Marcus Shawcroft
2014-09-18 12:02 ` [PATCH 5/14][AArch64] Use new reduc_[us](min|max)_scal optabs, inc. for builtins Alan Lawrence
2014-09-24 9:47 ` Marcus Shawcroft
2014-09-18 12:05 ` [PATCH 6/14][AArch64] Restore gimple_folding of reduction intrinsics Alan Lawrence
2014-09-24 9:48 ` Marcus Shawcroft
2014-09-18 12:19 ` [PATCH 7/14][Testsuite] Add tests of reductions using whole-vector-shifts (multiplication) Alan Lawrence
2014-09-22 10:41 ` Richard Biener
2014-09-18 12:25 ` [PATCH 8/14][Testsuite] Add tests of reductions using whole-vector-shifts (ior) Alan Lawrence
2014-09-22 10:42 ` Richard Biener
2014-09-18 12:27 ` [PATCH 9/14] Enforce whole-vector-shifts to always be by a whole number of elements Alan Lawrence
2014-09-22 10:50 ` Richard Biener
2014-09-18 12:34 ` [PATCH 10/14][AArch64] Implement vec_shr optab Alan Lawrence
2014-09-18 12:35 ` [PATCH 11/14] Remove VEC_LSHIFT_EXPR and vec_shl_optab Alan Lawrence
2014-09-22 10:52 ` Richard Biener
2014-10-27 18:45 ` Alan Lawrence
2014-10-27 20:24 ` Richard Biener
2014-09-18 12:43 ` [PATCH 12/14][Vectorizer] Redefine VEC_RSHIFT_EXPR and vec_shr_optab as endianness-neutral Alan Lawrence
2014-09-18 13:12 ` David Edelsohn
2014-09-22 13:27 ` Bill Schmidt
2014-09-22 10:58 ` Richard Biener
2014-09-18 12:45 ` Alan Lawrence [this message]
2014-09-22 10:52 ` [PATCH 13/14][AArch64_be] Fix vec_shr pattern to correctly implement endianness-neutral optab Richard Biener
2014-09-18 12:48 ` [PATCH 14/14][Vectorizer] Tidy up vect_create_epilog / use_scalar_result Alan Lawrence
2014-09-22 10:53 ` Richard Biener
2014-11-14 17:29 ` PUSHED: " Alan Lawrence
2014-09-18 12:58 ` [PATCH/RFC 15 / 14+2][RS6000] Remove vec_shl and (hopefully) fix vec_shr Alan Lawrence
2014-09-23 12:50 ` David Edelsohn
2014-09-18 13:02 ` [PATCH 16 / 14+2][MIPS] " Alan Lawrence
2014-09-22 11:21 ` [PATCH 0/14+2][Vectorizer] Made reductions endianness-neutral, fixes PR/61114 Richard Biener
2014-09-22 11:26 ` Richard Biener
2014-10-06 17:31 ` Alan Lawrence
[not found] ` <5432D1A5.6080208@arm.com>
2014-10-07 7:45 ` Richard Biener
2014-10-07 7:46 ` Richard Biener
[not found] ` <5436C138.50208@arm.com>
2014-10-09 17:13 ` Alan Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541AD3E4.2030200@arm.com \
--to=alan.lawrence@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).