* [patch] update comments on *_ultimate_origin
@ 2014-09-18 16:42 Aldy Hernandez
2014-09-18 18:25 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Aldy Hernandez @ 2014-09-18 16:42 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
output_inline_function was removed in tree-ssa times, no sense
referencing it a decade later.
I still see DECL_ABSTRACT_ORIGIN pointing to itself in some instances,
though I haven't tracked down where, so I assume we still need the
functionality, just not the comment :).
OK for mainline?
Aldy
[-- Attachment #2: curry --]
[-- Type: text/plain, Size: 1452 bytes --]
commit d51576de0a8450634ff7622e4688fd02fc8fcee9
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Thu Sep 18 10:35:30 2014 -0600
* dwarf2out.c (decl_ultimate_origin): Update comment.
* tree.c (block_ultimate_origin): Same.
diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index 23a80d8..c65c756 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -3676,8 +3676,7 @@ decl_ultimate_origin (const_tree decl)
if (!CODE_CONTAINS_STRUCT (TREE_CODE (decl), TS_DECL_COMMON))
return NULL_TREE;
- /* output_inline_function sets DECL_ABSTRACT_ORIGIN for all the
- nodes in the function to point to themselves; ignore that if
+ /* DECL_ABSTRACT_ORIGIN can point to itself; ignore that if
we're trying to output the abstract instance of this function. */
if (DECL_ABSTRACT (decl) && DECL_ABSTRACT_ORIGIN (decl) == decl)
return NULL_TREE;
diff --git a/gcc/tree.c b/gcc/tree.c
index d1d67ef..fc544de 100644
--- a/gcc/tree.c
+++ b/gcc/tree.c
@@ -11554,8 +11554,7 @@ block_ultimate_origin (const_tree block)
{
tree immediate_origin = BLOCK_ABSTRACT_ORIGIN (block);
- /* output_inline_function sets BLOCK_ABSTRACT_ORIGIN for all the
- nodes in the function to point to themselves; ignore that if
+ /* BLOCK_ABSTRACT_ORIGIN can point to itself; ignore that if
we're trying to output the abstract instance of this function. */
if (BLOCK_ABSTRACT (block) && immediate_origin == block)
return NULL_TREE;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] update comments on *_ultimate_origin
2014-09-18 16:42 [patch] update comments on *_ultimate_origin Aldy Hernandez
@ 2014-09-18 18:25 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2014-09-18 18:25 UTC (permalink / raw)
To: Aldy Hernandez, gcc-patches
On 09/18/14 10:42, Aldy Hernandez wrote:
> output_inline_function was removed in tree-ssa times, no sense
> referencing it a decade later.
>
> I still see DECL_ABSTRACT_ORIGIN pointing to itself in some instances,
> though I haven't tracked down where, so I assume we still need the
> functionality, just not the comment :).
>
> OK for mainline?
OK.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-18 18:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-18 16:42 [patch] update comments on *_ultimate_origin Aldy Hernandez
2014-09-18 18:25 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).