From: Yury Gribov <y.gribov@samsung.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>,
Maxim Ostapenko <m.ostapenko@partner.samsung.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>,
Slava Garbuzov <v.garbuzov@samsung.com>,
Maxim Ostapenko <chefmax7@gmail.com>,
ian@airs.com, dj@redhat.com
Subject: Re: [PATCH 2/2] Add patch for debugging compiler ICEs.
Date: Fri, 19 Sep 2014 03:33:00 -0000 [thread overview]
Message-ID: <541BA42A.3090003@samsung.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1409182210360.20342@digraph.polyomino.org.uk>
On 09/19/2014 02:16 AM, Joseph S. Myers wrote:
> On Thu, 11 Sep 2014, Maxim Ostapenko wrote:
>
>> In general, when cc1 or cc1plus ICE-es, we try to reproduce the bug by running
>> compiler 3 times and comparing stderr and stdout on each attempt with
>> respective ones that were gotten as the result of previous compiler run (we
>> use temporary dump files to do this). If these files are identical, we add GCC
>> configuration (e.g. target, configure options and version), compiler command
>> line and preprocessed source code into last dump file, containing backtrace.
>> Following Jakub's approach, we trigger ICE_EXIT_CODE instead of
>> FATAL_EXIT_CODE in case of DK_FATAL error to differ ICEs from other fatal
>> errors, so try_generate_repro routine will be able to run even if fatal_error
>> occurred in compiler.
>
> I still don't understand what's going on here with exit codes.
I'd second this, internal_error already exits with ICE_EXIT_CODE via
DK_ICE. Forcing fatal errors to return ICE_EXIT_CODE as well seems
unnecessary.
-Y
next prev parent reply other threads:[~2014-09-19 3:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 17:03 [PATCH] " Maxim Ostapenko
2014-08-12 16:14 ` [PING][PATCH] " Maxim Ostapenko
2014-08-19 13:58 ` Fwd: [PATCH] " Maxim Ostapenko
2014-08-28 7:31 ` [Ping v2][PATCH] " Maxim Ostapenko
2014-09-05 14:16 ` [Ping v3][PATCH] " Maxim Ostapenko
2014-09-09 22:51 ` [Ping v2][PATCH] " Joseph S. Myers
2014-09-10 4:57 ` Jakub Jelinek
2014-09-10 16:37 ` Joseph S. Myers
2014-09-11 16:18 ` [PATCH 1/2] Extend libiberty to allow append stdout and stderr to existing files Maxim Ostapenko
2014-09-11 16:33 ` Ian Lance Taylor
2014-09-11 16:20 ` [PATCH 2/2] Add patch for debugging compiler ICEs Maxim Ostapenko
2014-09-18 15:37 ` [PING] " Maxim Ostapenko
2014-09-18 22:17 ` Joseph S. Myers
2014-09-19 3:33 ` Yury Gribov [this message]
2014-09-23 7:15 ` Maxim Ostapenko
2014-09-25 19:05 ` Jeff Law
2014-09-26 8:04 ` Maxim Ostapenko
2014-09-26 13:11 ` Rainer Orth
2014-09-26 13:24 ` Thomas Schwinge
2014-09-26 13:32 ` Maxim Ostapenko
2014-09-26 16:18 ` Jeff Law
2014-09-26 16:31 ` Thomas Schwinge
2014-09-26 16:32 ` Jeff Law
2015-01-23 1:42 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541BA42A.3090003@samsung.com \
--to=y.gribov@samsung.com \
--cc=chefmax7@gmail.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=m.ostapenko@partner.samsung.com \
--cc=v.garbuzov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).