From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4789 invoked by alias); 19 Sep 2014 16:57:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4775 invoked by uid 89); 19 Sep 2014 16:57:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 19 Sep 2014 16:57:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8JGv9fx006951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 19 Sep 2014 12:57:09 -0400 Received: from pike.twiddle.home (vpn-53-86.rdu2.redhat.com [10.10.53.86]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8JGv7x6004816; Fri, 19 Sep 2014 12:57:08 -0400 Message-ID: <541C6062.5080702@redhat.com> Date: Fri, 19 Sep 2014 16:57:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: James Greenhalgh , gcc-patches@gcc.gnu.org CC: marcus.shawcroft@arm.com Subject: Re: [AArch64] Tighten predicates on SIMD shift intrinsics References: <1410424192-5243-1-git-send-email-james.greenhalgh@arm.com> In-Reply-To: <1410424192-5243-1-git-send-email-james.greenhalgh@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg01660.txt.bz2 On 09/11/2014 01:29 AM, James Greenhalgh wrote: > +;; Predicates used by the various SIMD shift operations. These > +;; fall in to 3 categories. > +;; Shifts with a range 0-(bit_size - 1) (aarch64_simd_shift_imm) > +;; Shifts with a range 1-bit_size (aarch64_simd_shift_imm_offset) > +;; Shifts with a range 0-bit_size (aarch64_simd_shift_imm_bitsize) > +(define_predicate "aarch64_simd_shift_imm_qi" > + (and (match_code "const_int") > + (match_test "aarch64_simd_const_bounds (op, 0, 7)"))) The function call should be removed and this should be written as (match_test "IN_RANGE (ival, 0, 7)") r~