From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19281 invoked by alias); 24 Sep 2014 14:55:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19272 invoked by uid 89); 24 Sep 2014 14:55:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 24 Sep 2014 14:55:06 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8OEsxDb005699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Sep 2014 10:54:59 -0400 Received: from [10.10.52.64] (vpn-52-64.rdu2.redhat.com [10.10.52.64]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8OEswZC004616; Wed, 24 Sep 2014 10:54:58 -0400 Message-ID: <5422DB41.1090800@redhat.com> Date: Wed, 24 Sep 2014 14:55:00 -0000 From: Andrew MacLeod User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Segher Boessenkool , Jakub Jelinek , Bernd Schmidt , gcc-patches , richard.sandiford@arm.com Subject: Re: parallel check output changes? References: <541AD692.4030907@redhat.com> <20140918130109.GH17454@tucnak.redhat.com> <541AD880.7080703@redhat.com> <541AF451.3070406@redhat.com> <541B1710.8060809@codesourcery.com> <20140918173609.GM17454@tucnak.redhat.com> <20140918184455.GB28595@gate.crashing.org> <20140919093723.GA26414@gate.crashing.org> <87iokel5c0.fsf@e105548-lin.cambridge.arm.com> In-Reply-To: <87iokel5c0.fsf@e105548-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg02129.txt.bz2 On 09/23/2014 11:33 AM, Richard Sandiford wrote: > Segher Boessenkool writes: >> On Thu, Sep 18, 2014 at 01:44:55PM -0500, Segher Boessenkool wrote: >>> I am testing a patch that is just >>> >>> >>> diff --git a/contrib/dg-extract-results.py b/contrib/dg-extract-results.py >>> index cccbfd3..3781423 100644 >>> --- a/contrib/dg-extract-results.py >>> +++ b/contrib/dg-extract-results.py >>> @@ -117,7 +117,7 @@ class Prog: >>> self.tool_re = re.compile (r'^\t\t=== (.*) tests ===$') >>> self.result_re = re.compile (r'^(PASS|XPASS|FAIL|XFAIL|UNRESOLVED' >>> r'|WARNING|ERROR|UNSUPPORTED|UNTESTED' >>> - r'|KFAIL):\s*(\S+)') >>> + r'|KFAIL):\s*(.+)') >>> self.completed_re = re.compile (r'.* completed at (.*)') >>> # Pieces of text to write at the head of the output. >>> # start_line is a pair in which the first element is a datetime >> Tested that with four runs on powerpc64-linux, four configs each time; >> test-summary >> shows the same in all cases. Many lines have moved compared to without >> the patch, but that cannot be helped. Okay for mainline? >> >> >> 2014-09-19 Segher Boessenkool >> >> contrib/ >> * dg-extract-results.py (Prog.result_re): Include options in test name. > FWIW, the \S+ thing was deliberate. When one test is run multiple times > with different options, those options aren't necessarily tried in > alphabetical order. The old sh/awk script therefore used just the test > name as the key and kept tests with the same name in the order that > they were encountered: > > /^(PASS|XPASS|FAIL|XFAIL|UNRESOLVED|WARNING|ERROR|UNSUPPORTED|UNTESTED|KFAIL):/ { > testname=\$2 > # Ugly hack for gfortran.dg/dg.exp > if ("$TOOL" == "gfortran" && testname ~ /^gfortran.dg\/g77\//) > testname="h"testname > } > > (note the "$2"). This means that the output of the script is in the same > order as it would be for non-parallel runs. I was following (or trying > to follow) that behaviour in the python script. > > Your patch instead sorts based on the full test name, including options, > which means that the output no longer matches what you'd get from a > non-parallel run. AFAICT, it also no longer matches what you'd get from > the .sh version. That might be OK, just thought I'd mention it. > > Thanks, > Richard > Is this suppose to be resolved now? I'm still seeing some issues with a branch cut from mainline from yesterday. This is from the following sequence: check out revision 215511 , build, make -j16 check, make -j16 check, then compare all the .sum files: PASS: gcc.dg/tls/asm-1.c (test for errors, line 7) PASS: gcc.dg/tls/asm-1.c (test for excess errors) PASS: gcc.dg/tls/debug-1.c (test for excess errors) PASS: gcc.dg/tls/diag-1.c (test for excess errors) PASS: gcc.dg/tls/diag-2.c (test for errors, line 4) PASS: gcc.dg/tls/diag-2.c (test for errors, line 5) PASS: gcc.dg/tls/diag-2.c (test for errors, line 6) PASS: gcc.dg/tls/diag-2.c (test for errors, line 7) PASS: gcc.dg/tls/diag-2.c (test for errors, line 11) PASS: gcc.dg/tls/diag-2.c (test for errors, line 12) PASS: gcc.dg/tls/diag-2.c (test for errors, line 13) PASS: gcc.dg/tls/diag-2.c (test for errors, line 14) PASS: gcc.dg/tls/diag-2.c (test for errors, line 17) PASS: gcc.dg/tls/diag-2.c (test for errors, line 18) PASS: gcc.dg/tls/diag-2.c (test for errors, line 19) PASS: gcc.dg/tls/diag-2.c (test for errors, line 20) PASS: gcc.dg/tls/diag-2.c (test for errors, line 22) and then PASS: gcc.dg/tls/asm-1.c (test for errors, line 7) PASS: gcc.dg/tls/asm-1.c (test for excess errors) PASS: gcc.dg/tls/debug-1.c (test for excess errors) PASS: gcc.dg/tls/diag-1.c (test for excess errors) PASS: gcc.dg/tls/diag-2.c (test for errors, line 11) PASS: gcc.dg/tls/diag-2.c (test for errors, line 12) PASS: gcc.dg/tls/diag-2.c (test for errors, line 13) PASS: gcc.dg/tls/diag-2.c (test for errors, line 14) PASS: gcc.dg/tls/diag-2.c (test for errors, line 17) PASS: gcc.dg/tls/diag-2.c (test for errors, line 18) PASS: gcc.dg/tls/diag-2.c (test for errors, line 19) PASS: gcc.dg/tls/diag-2.c (test for errors, line 20) PASS: gcc.dg/tls/diag-2.c (test for errors, line 22) PASS: gcc.dg/tls/diag-2.c (test for errors, line 4) PASS: gcc.dg/tls/diag-2.c (test for errors, line 5) PASS: gcc.dg/tls/diag-2.c (test for errors, line 6) PASS: gcc.dg/tls/diag-2.c (test for errors, line 7) it looks like the first time sorted by line numerically (or just happened to leave the run order) and the second time did the sort alphabetically... Andrew