public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] contrib: add unicode/utf8-dump.py
Date: Mon, 1 Nov 2021 15:36:40 +0100	[thread overview]
Message-ID: <5425251a-e35c-27f0-fde7-323365d73a13@suse.cz> (raw)
In-Reply-To: <20211101141404.1096747-1-dmalcolm@redhat.com>

On 11/1/21 15:14, David Malcolm via Gcc-patches wrote:
> |This script may be useful when debugging issues relating to Unicode encoding (e.g. when investigating source files with bidirectional control characters).|

I like the script except the following flake8 issues:

$ flake8 contrib/unicode/utf8-dump.py
contrib/unicode/utf8-dump.py:35:1: E302 expected 2 blank lines, found 1
contrib/unicode/utf8-dump.py:43:1: E302 expected 2 blank lines, found 1
contrib/unicode/utf8-dump.py:53:1: E302 expected 2 blank lines, found 1
contrib/unicode/utf8-dump.py:64:1: E305 expected 2 blank lines after class or function definition, found 1

Martin

  reply	other threads:[~2021-11-01 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 14:14 David Malcolm
2021-11-01 14:36 ` Martin Liška [this message]
2021-11-01 15:32   ` David Malcolm
2021-11-01 15:37     ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5425251a-e35c-27f0-fde7-323365d73a13@suse.cz \
    --to=mliska@suse.cz \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).