From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 08862385840A for ; Mon, 1 Nov 2021 14:36:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08862385840A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C28E21FD29; Mon, 1 Nov 2021 14:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635777400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2agbGvLTpRg/nGr/Q9YrjKXdTjd4fgMgbm0uJLw0oYI=; b=LUGoURY9MJnylkKyDR/ET5f0hCz23h0RaS7z5Hu07xBkYWzuRbFm1Gc/gWhTNzsrWyQXE8 dshxjVe5Y0hVkehnqFNvs7fvU/xoHm+GcdQ0wH1yc19yMzLFsAChvNvusPDyNmk6ckfSxp RpCQpmz3RaebtrDNkyZc3kWAd6mMy2g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635777400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2agbGvLTpRg/nGr/Q9YrjKXdTjd4fgMgbm0uJLw0oYI=; b=cwaACXf2M4FyggAGTVBKgp/wPvaiRpw1HtziqE3V2lnmEGEX7opvsO2UfGt86xpHJn0G8v C6lIAa4A1HeqU/Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A6EEC13A1F; Mon, 1 Nov 2021 14:36:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JRY1J3j7f2GBJwAAMHmgww (envelope-from ); Mon, 01 Nov 2021 14:36:40 +0000 Message-ID: <5425251a-e35c-27f0-fde7-323365d73a13@suse.cz> Date: Mon, 1 Nov 2021 15:36:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] contrib: add unicode/utf8-dump.py Content-Language: en-US To: David Malcolm , gcc-patches@gcc.gnu.org References: <20211101141404.1096747-1-dmalcolm@redhat.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20211101141404.1096747-1-dmalcolm@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 14:36:43 -0000 On 11/1/21 15:14, David Malcolm via Gcc-patches wrote: > |This script may be useful when debugging issues relating to Unicode encoding (e.g. when investigating source files with bidirectional control characters).| I like the script except the following flake8 issues: $ flake8 contrib/unicode/utf8-dump.py contrib/unicode/utf8-dump.py:35:1: E302 expected 2 blank lines, found 1 contrib/unicode/utf8-dump.py:43:1: E302 expected 2 blank lines, found 1 contrib/unicode/utf8-dump.py:53:1: E302 expected 2 blank lines, found 1 contrib/unicode/utf8-dump.py:64:1: E305 expected 2 blank lines after class or function definition, found 1 Martin