Re: [PATCH 2/2] Add patch for debugging compiler ICEs.

[Jeff Law <law@redhat.com>]

On 09/26/14 07:23, Thomas Schwinge wrote:
> Hi!
>
> On Fri, 26 Sep 2014 12:04:45 +0400, Maxim Ostapenko <m.ostapenko@partner.samsung.com> wrote:
>> Thank you all for your help!
>>
>> Done in r215633.
>>
>> -Maxim
>> On 09/25/2014 11:05 PM, Jeff Law wrote:
>>> On 09/23/14 01:14, Maxim Ostapenko wrote:
>>>>
>>>>
>>>> 2014-09-04  Jakub Jelinek<jakub@redhat.com>
>>>>          Max Ostapenko<m.ostapenko@partner.samsung.com>
>>>>
>>>>      * common.opt: New option.
>>>>      * doc/invoke.texi: Describe new option.
>>>>      * gcc.c (execute): Don't free first string early, but at the end
>>>>      of the function.  Call retry_ice if compiler exited with
>>>>      ICE_EXIT_CODE.
>>>>      (main): Factor out common code.
>>>>      (print_configuration): New function.
>>>>      (files_equal_p): Likewise.
>>>>      (check_repro): Likewise.
>>>>      (run_attempt): Likewise.
>>>>      (do_report_bug): Likewise.
>>>>      (append_text): Likewise.
>>>>      (try_generate_repro): Likewise
>>> Approved.  Please install.
>>>
>>> Thanks for your patience,
>>> Jeff
>
> This is causing compiler warnings, respectively bootstrap errors:
>
>      [...]
>      ../../master/gcc/gcc.c: In function 'attempt_status run_attempt(const char**, const char*, const char*, int, int)':
>      ../../master/gcc/gcc.c:6319:15: error: variable 'errmsg' set but not used [-Werror=unused-but-set-variable]
>         const char *errmsg;
>                     ^
>      ../../master/gcc/gcc.c: At global scope:
>      ../../master/gcc/gcc.c:6412:33: error: unused parameter 'prog' [-Werror=unused-parameter]
>       try_generate_repro (const char *prog, const char **argv)
>                                       ^
>      cc1plus: all warnings being treated as errors
>      Makefile:1040: recipe for target 'gcc.o' failed
>      make[3]: *** [gcc.o] Error 1
>      make[3]: Leaving directory '/media/erich/home/thomas/tmp/gcc/hurd/master.build/gcc'
>      Makefile:4285: recipe for target 'all-stage2-gcc' failed
>      make[2]: *** [all-stage2-gcc] Error 2
>      make[2]: Leaving directory '/media/erich/home/thomas/tmp/gcc/hurd/master.build'
>      Makefile:21561: recipe for target 'stage2-bubble' failed
>      make[1]: *** [stage2-bubble] Error 2
>      make[1]: Leaving directory '/media/erich/home/thomas/tmp/gcc/hurd/master.build'
>      Makefile:892: recipe for target 'all' failed
>      make: *** [all] Error 2
>
> OK to fix as follows?  Only compile-tested, did not test the new
> -freport-bug functionality.
[ ... ]
Please construct a ChangeLog and commit.  Thanks.

jeff