From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp001-out.apm-internet.net (smtp001-out.apm-internet.net [85.119.248.222]) by sourceware.org (Postfix) with ESMTPS id 2F0563850871 for ; Thu, 20 Oct 2022 15:23:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F0563850871 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sandoe.co.uk Received: (qmail 67358 invoked from network); 20 Oct 2022 15:23:37 -0000 X-APM-Out-ID: 16662794176735 X-APM-Authkey: 257869/1(257869/1) 4 Received: from unknown (HELO ?192.168.1.95?) (81.138.1.83) by smtp001.apm-internet.net with SMTP; 20 Oct 2022 15:23:37 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions From: Iain Sandoe In-Reply-To: Date: Thu, 20 Oct 2022 16:23:36 +0100 Cc: "Lu, Hongjiu" , hongtao.liu@intel.com, GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: <542BB22B-10AA-410A-9097-61D44FC4D24A@sandoe.co.uk> References: <20221014075445.7938-1-haochen.jiang@intel.com> <59C4B6AD-CC12-4D2A-9F9E-E44404BDF41A@googlemail.com> <4D6C9639-D637-454C-82DF-925830604EEC@googlemail.com> To: Hongtao Liu X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,KAM_COUK,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Hongtao, > On 20 Oct 2022, at 10:20, Hongtao Liu wrote: >=20 > On Thu, Oct 20, 2022 at 5:17 PM Iain Sandoe = wrote: >>=20 >>=20 >>=20 >>> On 20 Oct 2022, at 10:09, Hongtao Liu via Gcc-patches = wrote: >>>=20 >>> On Thu, Oct 20, 2022 at 9:11 AM Hongtao Liu = wrote: >>>>=20 >>>> On Wed, Oct 19, 2022 at 7:09 PM Iain Sandoe = wrote: >>>>>> On 17 Oct 2022, at 02:56, Hongtao Liu wrote: >>>>>>=20 >>>>>> On Mon, Oct 17, 2022 at 9:30 AM Bernhard Reutner-Fischer >>>>>> wrote: >>>>>>>=20 >>>>>>> On 17 October 2022 03:02:22 CEST, Hongtao Liu via Gcc-patches >>>>>>>=20 >>>>>>>>>>> Do you have this series as a branch somewhere that I can try = on one of the >>>>>>>>>>> like affected platforms? >>>>>>>>>>=20 >>>>>>>>>> Not yet. >>>>>>>>>> Do we have any external place to put those patches so folks = from the >>>>>>>>>> community can validate before it's committed, HJ? >>>>>>>=20 >>>>>>>=20 >>>>>>> https://gcc.gnu.org/gitwrite.html#vendor >>>>>>>=20 >>>>>>> Not sure where in cgit the user branches are visible, though? = But they can certainly be cloned and worked with. >>>>>> Thanks for the reminder, I've pushed to = remotes/vendors/ix86/ise046. >>>>>> * [new ref] refs/vendors/ix86/heads/ise046 -> >>>>>> vendors/ix86/ise046 >>>>>=20 >>>>> thanks for pushing this branch, much better to test these things = before committing rather than a panic >>>>> to fix after=E2=80=A6 >>>>>=20 >>>>>=20 >>>>> with >>>>> f90df941532 (HEAD -> ise046, vendors/ix86/ise046) Add m_CORE_ATOM = for atom cores >>>>>=20 >>>>> - on x86_64 Darwin19 I get the following bootstrap fail: >>>>>=20 >>>>> In file included from = /src-local/gcc-master/gcc/config/i386/driver-i386.cc:31: >>>>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h: In = function =E2=80=98const char* get_intel_cpu(__processor_model*, = __processor_model2*, unsigned int*)=E2=80=99: >>>>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h:532:32: = error: this statement may fall through [-Werror=3Dimplicit-fallthrough=3D]= >>>>> 532 | cpu_model->__cpu_subtype =3D = INTEL_COREI7_GRANITERAPIDS; >>>>> | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h:533:5: = note: here >>>>> 533 | case 0xb6: >>>>> | ^~~~ >>>>> cc1plus: all warnings being treated as errors >>>>>=20 >>>>> =3D=3D=3D=3D >>>>> Will try to look later, if that does not immediately ring some = bell. >>>> This should a bug, thanks! >>> I've updated the branch, please try that. >>=20 >> I had made the same fix locally (adding the =E2=80=9Cbreak=E2=80=9D, = right?) and testing is ongoing > Yes, please go ahead. Thanks for giving me a chance to test, this seems OK on Darwin (no = large-scale fallout, anyway) .. =20 I tested the ise046 branch which looks like it collects several of the = posted patch series, so I=E2=80=99ve covered those too. (not had a chance to test on = AVX512 yet, but if the series is basically OK on skylake, then should be not too much = issue). Iain P.S. I am usually able to test patches / series like this on Darwin if = you point me at a branch.