public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch] remove dwarf2out's current_function_has_inlines
@ 2014-10-07 17:16 Aldy Hernandez
  2014-10-07 17:56 ` Jason Merrill
  0 siblings, 1 reply; 2+ messages in thread
From: Aldy Hernandez @ 2014-10-07 17:16 UTC (permalink / raw)
  To: jason merrill, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 59 bytes --]

Errr... a static that only gets written to?

OK to commit?

[-- Attachment #2: curr --]
[-- Type: text/plain, Size: 1366 bytes --]

commit 7b1c19385fd06d6a2d0844d453bf1c7683071440
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Tue Oct 7 10:14:02 2014 -0700

    	* dwarf2out.c: Remove current_function_has_inlines.
    	(gen_subprogram_die): Same.
    	(gen_inlined_subroutine_die): Same.

diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index b5fcfa4..1b30ea9 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -2954,9 +2954,6 @@ static GTY(()) unsigned int loclabel_num;
 /* Unique label counter for point-of-call tables.  */
 static GTY(()) unsigned int poc_label_num;
 
-/* Record whether the function being analyzed contains inlined functions.  */
-static int current_function_has_inlines;
-
 /* The last file entry emitted by maybe_emit_file().  */
 static GTY(()) struct dwarf_file_data * last_emitted_file;
 
@@ -18613,7 +18610,6 @@ gen_subprogram_die (tree decl, dw_die_ref context_die)
       if (DECL_NAME (DECL_RESULT (decl)))
 	gen_decl_die (DECL_RESULT (decl), NULL, subr_die);
 
-      current_function_has_inlines = 0;
       decls_for_scope (outer_scope, subr_die, 0);
 
       if (call_arg_locations && !dwarf_strict)
@@ -19270,7 +19266,6 @@ gen_inlined_subroutine_die (tree stmt, dw_die_ref context_die, int depth)
       add_call_src_coords_attributes (stmt, subr_die);
 
       decls_for_scope (stmt, subr_die, depth);
-      current_function_has_inlines = 1;
     }
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] remove dwarf2out's current_function_has_inlines
  2014-10-07 17:16 [patch] remove dwarf2out's current_function_has_inlines Aldy Hernandez
@ 2014-10-07 17:56 ` Jason Merrill
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Merrill @ 2014-10-07 17:56 UTC (permalink / raw)
  To: Aldy Hernandez, gcc-patches

On 10/07/2014 01:16 PM, Aldy Hernandez wrote:
> Errr... a static that only gets written to?
>
> OK to commit?

Yes.  This should have been removed with

     2010-09-03  Marcin Baczynski  <marbacz@gmail.com>

         * dwarf2out.c (file scope): Remove #if0'd code.
         (gen_subprogram_die): Same.

Jason

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-07 17:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-07 17:16 [patch] remove dwarf2out's current_function_has_inlines Aldy Hernandez
2014-10-07 17:56 ` Jason Merrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).