From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1818 invoked by alias); 9 Oct 2014 07:26:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1732 invoked by uid 89); 9 Oct 2014 07:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f46.google.com Received: from mail-qg0-f46.google.com (HELO mail-qg0-f46.google.com) (209.85.192.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 09 Oct 2014 07:26:32 +0000 Received: by mail-qg0-f46.google.com with SMTP id z60so804355qgd.19 for ; Thu, 09 Oct 2014 00:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=BJfxzvdWU+5y1pRbksrBef/R1Sy8Z5oeBezk/b0X0Z0=; b=hACeaB1RATJ60x3XOx+QrS+1k1BgK68byHqrtPud57ynL/4+n6NVrM+TPU5LHl5QGk aBL+W2BJDU4vTNoQ6/4AWxUM+NLNLY72Gng2ppS1BRqc8gaxGwUdaxSpsQwk4p4C+HEf Ij62SNOj+ZU4w26CHQ3kXv1p88K57blzFfTTnVBWiGTh26kLojMdtQXqK8elAmqaBd+t B8RbhtBlsRL21muZ67/IgE+oPfu6qcD3rFdD+RPh+iZrD5dCy/E5R2mwSnn59stotwRa ErtyzTQt3Ud6RbwXPjv/H9hY8bMx734BERn0wyZ5656IiquVL6MJGcFnAiJnOtgxuXKx I+0g== X-Gm-Message-State: ALoCoQmiJHlgK801tQIWx8/gKe9B1+VdB3/eQzVekesZjtMjr4FmVdYlDwA1tOhB7nmWdmOy4xow X-Received: by 10.224.51.138 with SMTP id d10mr17780828qag.37.1412839590001; Thu, 09 Oct 2014 00:26:30 -0700 (PDT) Received: from [192.168.2.118] (ip70-176-172-237.ph.ph.cox.net. [70.176.172.237]) by mx.google.com with ESMTPSA id a3sm1767332qaa.49.2014.10.09.00.26.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Oct 2014 00:26:29 -0700 (PDT) Message-ID: <543638A0.6030705@linaro.org> Date: Thu, 09 Oct 2014 07:26:00 -0000 From: Michael Collison User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Andrew Pinski CC: GCC Patches Subject: Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes References: <543633BD.9030004@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00734.txt.bz2 Yes this problem was found with Christophe's neon intrinsic tests which are awaiting approval. The problem was found by passing a value of zero to the vclz vector intrinsic. On 10/09/2014 12:11 AM, Andrew Pinski wrote: > On Thu, Oct 9, 2014 at 12:05 AM, Michael Collison > wrote: >> The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the vector >> intrinsic vclz this is incorrect and should return the value eight. The >> CTZ_DEFINED_VALUE_AT_ZERO has the same issue. > > Do you have a testcase? I almost think you should have a testcase > which causes the constant folding. Though I don't think there is > constant folding of the vector clz/ctz happening. > > Thanks, > Andrew > >> Tested on arm-linux-gnueabihf, arm-linux-gnueabi. >> >> 2014-10-08 Michael Collison >> >> * config/arm/arm.h (CLZ_DEFINED_VALUE_AT_ZERO) : Update >> to support vector modes >> (CTZ_DEFINED_VALUE_AT_ZERO): Ditto >> >> -- >> Michael Collison >> Linaro Toolchain Working Group >> michael.collison@linaro.org >> -- Michael Collison Linaro Toolchain Working Group michael.collison@linaro.org