From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25311 invoked by alias); 10 Oct 2014 16:03:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25295 invoked by uid 89); 10 Oct 2014 16:03:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 10 Oct 2014 16:03:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9AG3dYD028204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Oct 2014 12:03:39 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-95.phx2.redhat.com [10.3.113.95]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9AG3cbp010789; Fri, 10 Oct 2014 12:03:39 -0400 Message-ID: <5438035A.1030408@redhat.com> Date: Fri, 10 Oct 2014 16:11:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Evgeny Stupachenko , vmakarov , Uros Bizjak , GCC Patches Subject: Re: [PATCH 1/X, i386, PR54232] Enable EBX for x86 in 32bits PIC code References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00965.txt.bz2 On 10/10/14 01:42, Evgeny Stupachenko wrote: > Hi, > > The patch enables EBX in RA for x86 32bits PIC mode. > It was discussed here: https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02513.html > Now there is working version with good performance and stability level > - it could be a solid first step of EBX enabling. > > Bootstrap and make check passed. > There are several changes in "-m32" make check. > > New pass: > gcc.target/i386/pr57003.c - before patch there was not enough registers to PASS ?!? That doesn't make a lot of sense. More likely it was Uros's fix from yesterday to regcprop which causes this to pass again. Is it possible you updated your sources between testing runs and as a result picked up Uros's fix? > > New fails: > > gcc.target/i386/pic-1.c (test for errors, line 12) - now there are no > errors as we can do asm insertions with EBX I think you should remove the dg-error directive. That turns this test into a simple confirmation that we can use %ebx in an asm even when generating PIC code. Can you add a PR markers to your changelog PR target/8340 PR middle-end/47602 PR rtl-optimization/55458 Actually I think there is an additional test in 47602. Can you please add it to the suite? You'll also want to change the state of 47602 to RESOLVED/FIXED. > gcc.target/i386/pr23098.c scan-assembler-not .LC[0-9] - potential > performance opportunity using constant immediate If you're not going to fix it, then you should xfail it. > gcc.target/i386/pr55458.c (test for errors, line 10) - now there are > no errors as there enough registers Right. Remove the dg-error and turn this into a test that effective verifies that %ebx is no longer fixed when generating PIC code on i686. With those changes this is OK for the trunk. jeff