From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11818 invoked by alias); 11 Oct 2014 01:28:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11804 invoked by uid 89); 11 Oct 2014 01:28:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 11 Oct 2014 01:28:08 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9B1S5qC027801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Oct 2014 21:28:05 -0400 Received: from [10.10.63.128] (vpn-63-128.rdu2.redhat.com [10.10.63.128]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9B1S4FT009539; Fri, 10 Oct 2014 21:28:04 -0400 Message-ID: <543887A3.3020803@redhat.com> Date: Sat, 11 Oct 2014 01:42:00 -0000 From: Andrew MacLeod User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jeff Law CC: "Joseph S. Myers" , gcc-patches , Richard Biener Subject: Re: [patch] Flatten function.h take 2 References: <54188D7E.4090701@redhat.com> <5418AA5D.2090602@redhat.com> <542995A6.5040200@redhat.com> <543846EE.3070907@redhat.com> In-Reply-To: <543846EE.3070907@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg01040.txt.bz2 On 10/10/2014 04:51 PM, Jeff Law wrote: > On 09/29/14 11:23, Andrew MacLeod wrote: > >> OK, here's take 2.. I left all the include files except ones which were >> duplicated as a result of the flattening. The first one was left, and >> any subsequent #Includes of the files were removed. we'll address >> "unneeded" includes separately and all at once.. perhaps with a newer >> tool that has been taught about input and output dependencies >> >> Bootstrapepd on x86_64-unknown-linux-gnu with no new regressions. >> Currently config-list.mk is building, but Im not expecting any issues >> there. assuming all is oK, ok to check in? >> >> Andrew >> >> PS.. the original commentary: >> >> This flattens function.h. It wasn't too bad, there were a few >> prototypes and defines in expr.h and rtl.h that belong in function.h, >> and a couple of other prototypes that belonged in other .h files. A >> bunch of the gen*.c generated files actually use function.h.. so they >> needed some tweaking. > This version is fine assuming your testing went OK. It's a highly > mechanical patch once you get to the .c files. SO it wasn't nearly as > bad as I expected when I saw its size :-) > Yeah.. the nature of these flattening patches.. they tend to look very large, but in reality only the first few files tend to have any changes that aren't mechanical. i use to list them in separate patches, now I just list them first and try to describe the bits that are not obvious :) Thanks Andrew PS. Testing went fine :-)