From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14606 invoked by alias); 15 Oct 2014 17:33:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14588 invoked by uid 89); 15 Oct 2014 17:33:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Oct 2014 17:33:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9FHXfGZ015957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Oct 2014 13:33:42 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-95.phx2.redhat.com [10.3.113.95]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9FHXf9Z026066; Wed, 15 Oct 2014 13:33:41 -0400 Message-ID: <543EAFF5.3000403@redhat.com> Date: Wed, 15 Oct 2014 17:34:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/5] libiberty: Expose choose_tmpdir, and fix constness of return type References: <1413222308-25753-1-git-send-email-dmalcolm@redhat.com> <1413222308-25753-2-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1413222308-25753-2-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg01405.txt.bz2 On 10/13/14 11:45, David Malcolm wrote: > The jit needs to create a temporary directory, so I need to expose > libiberty's choose_tmpdir as a public entrypoint. > > include/ChangeLog: > * libiberty.h (choose_tmpdir): New prototype. > > libiberty/ChangeLog: > * choose-temp.c (choose_tmpdir): Remove now-redundant local > copy of prototype. > * functions.texi: Regenerate. > * make-temp-file.c (choose_tmpdir): Convert return type from > char * to const char * - given that this returns a pointer to > a memoized allocation, the caller must not touch it. OK. Jeff