From: Jeff Law <law@redhat.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>,
Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)
Date: Wed, 15 Oct 2014 21:53:00 -0000 [thread overview]
Message-ID: <543EEBA4.2030907@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1410152143150.11645@digraph.polyomino.org.uk>
On 10/15/14 15:46, Joseph S. Myers wrote:
> On Wed, 15 Oct 2014, Marek Polacek wrote:
>
>> We've got a complaint that the "dereferencing pointer to incomplete
>> type" error is printed for all occurrences of the incomplete type,
>> which is too verbose. Also it'd be nicer to print the type as well.
>> This patch fixes this; if we find an incomplete type, mark it with error
>> node, then we don't print the error message more than once.
>
> I don't like this approach of modifying the type; type nodes are shared
> objects and this could affect all sorts of other logic subsequently
> working with the type. I think there should be some sort of annotation of
> the type (either in the type itself, or on the side) that *only* means an
> error has been given for the type being incomplete, rather than inserting
> error_mark_node into the type.
Isn't slamming error_mark_node well established at this point? I fact I
recall seeing it documented to be used in this kind of way to prevent
future errors.
jeff
next prev parent reply other threads:[~2014-10-15 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 17:29 Marek Polacek
2014-10-15 21:10 ` Jeff Law
2014-10-15 21:48 ` Joseph S. Myers
2014-10-15 21:53 ` Jeff Law [this message]
2014-10-15 21:57 ` Jakub Jelinek
2014-10-16 17:26 ` Marek Polacek
2014-10-15 22:08 ` Joseph S. Myers
2014-10-16 17:20 ` Marek Polacek
2014-10-16 22:09 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543EEBA4.2030907@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).