public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch]add function.h flattened includes to gcc-plugin.h
@ 2014-10-16 20:54 Andrew MacLeod
  2014-10-16 22:09 ` Jeff Law
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew MacLeod @ 2014-10-16 20:54 UTC (permalink / raw)
  To: gcc-patches, Jeff Law, David Malcolm

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

In an attempt to not screw up every plugin user again this release, I'll 
try to add any flattened includes and any pre-requiresites into 
gcc-plugin.h, as discussed here: 
https://gcc.gnu.org/ml/gcc/2014-10/msg00127.html

This patch adds those includes to gcc-plugin.h, and also adds tm.h since 
it is a prerequisite for function.h.

I also revert the changes to testsuite/g++.dg/plugin/pragma_plugin.c so 
that it simply includes function.h like it did before...  thats the 
proof of compilation I guess :-)

Pretty trivial change, and still bootstraps 
onx86_64-unknown-linux-gnu...   and doesn't cause any regressions I can 
see.,

OK?

Andrew




[-- Attachment #2: plug.patch --]
[-- Type: text/x-patch, Size: 1123 bytes --]


	* gcc-plugin.h:  Add tm.h and flattened includes from function.h.

	* testsuite/g++.dg/plugin/pragma_plugin.c: Revert flattening, only
	include function.h.


Index: gcc-plugin.h
===================================================================
--- gcc-plugin.h	(revision 216336)
+++ gcc-plugin.h	(working copy)
@@ -28,7 +28,13 @@
 #include "system.h"
 #include "coretypes.h"
 #include "highlev-plugin-common.h"
+#include "tm.h"
 #include "hashtab.h"
+#include "hash-set.h"
+#include "vec.h"
+#include "machmode.h"
+#include "hard-reg-set.h"
+#include "input.h"
 
 /* Event names.  */
 enum plugin_event
Index: testsuite/g++.dg/plugin/pragma_plugin.c
===================================================================
--- testsuite/g++.dg/plugin/pragma_plugin.c	(revision 216337)
+++ testsuite/g++.dg/plugin/pragma_plugin.c	(working copy)
@@ -8,12 +8,6 @@
 #include "tm.h"
 #include "rtl.h"
 #include "tree.h"
-#include "hashtab.h"
-#include "hash-set.h"
-#include "vec.h"
-#include "machmode.h"
-#include "hard-reg-set.h"
-#include "input.h"
 #include "function.h"
 #include "c-family/c-pragma.h"
 #include "cpplib.h"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch]add function.h flattened includes to gcc-plugin.h
  2014-10-16 20:54 [patch]add function.h flattened includes to gcc-plugin.h Andrew MacLeod
@ 2014-10-16 22:09 ` Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2014-10-16 22:09 UTC (permalink / raw)
  To: Andrew MacLeod, gcc-patches, David Malcolm

On 10/16/14 14:52, Andrew MacLeod wrote:
> In an attempt to not screw up every plugin user again this release, I'll
> try to add any flattened includes and any pre-requiresites into
> gcc-plugin.h, as discussed here:
> https://gcc.gnu.org/ml/gcc/2014-10/msg00127.html
>
> This patch adds those includes to gcc-plugin.h, and also adds tm.h since
> it is a prerequisite for function.h.
>
> I also revert the changes to testsuite/g++.dg/plugin/pragma_plugin.c so
> that it simply includes function.h like it did before...  thats the
> proof of compilation I guess :-)
>
> Pretty trivial change, and still bootstraps
> onx86_64-unknown-linux-gnu...   and doesn't cause any regressions I can
> see.,
>
> OK?
OK.
jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-16 22:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-16 20:54 [patch]add function.h flattened includes to gcc-plugin.h Andrew MacLeod
2014-10-16 22:09 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).