From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19239 invoked by alias); 21 Oct 2014 15:22:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19222 invoked by uid 89); 21 Oct 2014 15:22:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 21 Oct 2014 15:22:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9LFMkM4002086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 21 Oct 2014 11:22:46 -0400 Received: from [10.3.113.119] (ovpn-113-119.phx2.redhat.com [10.3.113.119]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9LFMjlk026071; Tue, 21 Oct 2014 11:22:45 -0400 Message-ID: <54467A48.9010706@redhat.com> Date: Tue, 21 Oct 2014 15:24:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Bernd Schmidt , GCC Patches Subject: Re: [3/6] nvptx testsuite patches: stdio References: <5446694A.1010705@codesourcery.com> <54466B03.6030706@codesourcery.com> In-Reply-To: <54466B03.6030706@codesourcery.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg02105.txt.bz2 On 10/21/14 14:17, Bernd Schmidt wrote: > Some tests use stdio functions which are unavaiable with the cut-down > newlib I'm using for ptx testing. I'm somewhat uncertain what to do with > these; they are by no means the only unavailable library functions the > testsuite tries to use (signal is another example). Here's a patch which > deals with parts of the problem, but I wouldn't mind leaving this one > out if it doesn't seem worthwhile. Tests probably shouldn't be using stdio anyway, except perhaps for the wrapper used when we run remotes and such to print the PASS/FAIL message. One could argue a better direction would be to change calls into stdio to instead call some other function defined in the same .c file. That "other function" would be marked as noinline. That would help minimize the possibility of compromising the test. Jeff