From: Jiong Wang <jiong.wang@arm.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Second basic-block.h restructuring patch.
Date: Tue, 21 Oct 2014 15:53:00 -0000 [thread overview]
Message-ID: <5446804D.2040308@arm.com> (raw)
In-Reply-To: <544552B7.8070007@redhat.com>
On 20/10/14 19:21, Andrew MacLeod wrote:
> creates cfg.h, cfganal.h, lcm.h, and loop-unroll.h to house the
> prototypes for those .c files.
>
> cfganal.h also gets "struct edge_list" and "class control_dependences"
> definitions since that is where all the routines and manipulators are
> declared.
>
> loop-unroll.h only exports 2 routines, so rather than including that
> in basic-block.h I simply included it from the 2 .c files which consume
> those routines. Again, the other includes will be flattened out of
> basic-block.h to just their consumers later.
>
> loop-unroll.c also had one function I marked as static since it wasn't
> actually used anywhere else.
>
> bootstraps on x86_64-unknown-linux-gnu, and regressions are running... I
> expect no regressions because of the nature of the changes. OK to
> check in assuming everything is OK?
Happen to start a fresh build
../gcc/configure --target=arm-none-linux-gnueabihf --enable-languages=c,c++
with the following error.
cnumber -I../../gcc/gcc/../libbacktrace -o loop-doloop.o -MT loop-doloop.o -MMD -MP -MF ./.deps/loop-doloop.TPo ../../gcc/gcc/loop-doloop.c
../../gcc/gcc/loop-doloop.c: In function ‘bool add_test(rtx, edge_def**, basic_block)’:
../../gcc/gcc/loop-doloop.c:371:38: error: ‘split_edge_and_insert’ was not declared in this scope
>
> Andrew
next prev parent reply other threads:[~2014-10-21 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 18:39 Andrew MacLeod
2014-10-21 7:58 ` Richard Biener
2014-10-21 15:53 ` Jiong Wang [this message]
2014-10-21 16:42 ` Andrew MacLeod
2014-10-21 16:45 ` Jiong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5446804D.2040308@arm.com \
--to=jiong.wang@arm.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).