From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21749 invoked by alias); 21 Oct 2014 16:30:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21630 invoked by uid 89); 21 Oct 2014 16:30:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 21 Oct 2014 16:30:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9LGUSI0029566 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 21 Oct 2014 12:30:28 -0400 Received: from [10.10.53.38] (vpn-53-38.rdu2.redhat.com [10.10.53.38]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9LGURvr028609; Tue, 21 Oct 2014 12:30:28 -0400 Message-ID: <54468A23.2000309@redhat.com> Date: Tue, 21 Oct 2014 16:42:00 -0000 From: Andrew MacLeod User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Jiong Wang CC: gcc-patches Subject: Re: [patch] Second basic-block.h restructuring patch. References: <544552B7.8070007@redhat.com> <5446804D.2040308@arm.com> In-Reply-To: <5446804D.2040308@arm.com> Content-Type: multipart/mixed; boundary="------------050202040503090200030404" X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg02137.txt.bz2 This is a multi-part message in MIME format. --------------050202040503090200030404 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-length: 936 On 10/21/2014 11:48 AM, Jiong Wang wrote: > >> >> bootstraps on x86_64-unknown-linux-gnu, and regressions are running... I >> expect no regressions because of the nature of the changes. OK to >> check in assuming everything is OK? > > Happen to start a fresh build > > ../gcc/configure --target=arm-none-linux-gnueabihf > --enable-languages=c,c++ > > with the following error. > > cnumber -I../../gcc/gcc/../libbacktrace -o loop-doloop.o -MT > loop-doloop.o -MMD -MP -MF ./.deps/loop-doloop.TPo > ../../gcc/gcc/loop-doloop.c > ../../gcc/gcc/loop-doloop.c: In function ‘bool add_test(rtx, > edge_def**, basic_block)’: > ../../gcc/gcc/loop-doloop.c:371:38: error: ‘split_edge_and_insert’ was > not declared in this scope > > Try the following patch. Apparently missed because that target is not in contrib/config-list.mk and no other target must have enabled that code path. Seems to work now. checked in as obvious. Andrew --------------050202040503090200030404 Content-Type: text/x-patch; name="doloop.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="doloop.patch" Content-length: 447 * loop-doloop.c: Include loop-unroll.h. Index: loop-doloop.c =================================================================== --- loop-doloop.c (revision 216517) +++ loop-doloop.c (working copy) @@ -33,6 +33,7 @@ #include "params.h" #include "target.h" #include "dumpfile.h" +#include "loop-unroll.h" /* This module is used to modify loops with a determinable number of iterations to use special low-overhead looping instructions. --------------050202040503090200030404--