From: Jeff Law <law@redhat.com>
To: gcc-patches@gcc.gnu.org, vmakarov@redhat.com, ubizjak@gmail.com,
markus@trippelsdorf.de, Ganesh.Gopalasubramanian@amd.com,
richard.sandiford@arm.com
Subject: Re: [PATCH 3/5] Pass an alternative_mask to constrain_operands
Date: Tue, 21 Oct 2014 17:46:00 -0000 [thread overview]
Message-ID: <54469937.9080001@redhat.com> (raw)
In-Reply-To: <87vbniagwq.fsf@e105548-lin.cambridge.arm.com>
On 10/17/14 14:51, Richard Sandiford wrote:
> After the previous patch there are cases where we want to constrain
> operands to any enabled alternative and cases where we want to also take
> size/speed preferences into account. The former applies when
> constraining an existing instruction (which might originally have been
> in a block with a different size/speed choice) or when making global
> decisions. The latter applies when evaluating a potential optimisation.
>
> This patch therefore passes the mask of allowable alternatives as a
> parameter to constrain_operands.
>
> Richard
>
>
> gcc/
> * recog.h (constrain_operands): Add an alternative_mask parameter.
> (constrain_operands_cached): Likewise.
> (get_preferred_alternatives): Declare new form.
> * recog.c (get_preferred_alternatives): New bb-taking instance.
> (constrain_operands): Take the set of available alternatives as
> a parameter.
> (check_asm_operands, insn_invalid_p, extract_constrain_insn)
> (extract_constrain_insn_cached): Update calls to constrain_operands.
> * caller-save.c (reg_save_code): Likewise.
> * ira.c (setup_prohibited_mode_move_regs): Likewise.
> * postreload-gcse.c (eliminate_partially_redundant_load): Likewise.
> * ree.c (combine_reaching_defs): Likewise.
> * reload.c (can_reload_into): Likewise.
> * reload1.c (reload, reload_as_needed, inc_for_reload): Likewise.
> (gen_reload_chain_without_interm_reg_p, emit_input_reload_insns)
> (emit_insn_if_valid_for_reload): Likewise.
> * reorg.c (fill_slots_from_thread): Likewise.
> * config/i386/i386.c (ix86_attr_length_address_default): Likewise.
> * config/pa/pa.c (pa_can_combine_p): Likewise.
> * config/rl78/rl78.c (insn_ok_now): Likewise.
> * config/sh/sh.md (define_peephole2): Likewise.
> * final.c (final_scan_insn): Update call to constrain_operands_cached.
>
OK. Thanks for taking care of this.
Jeff
next prev parent reply other threads:[~2014-10-21 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 14:47 [PATCH 0/5] Add preferred_for_{size,speed} attributes Richard Sandiford
2014-10-17 14:48 ` [PATCH 1/5] Add recog_constrain_insn Richard Sandiford
2014-10-21 14:56 ` Vladimir Makarov
2014-10-21 15:45 ` Jeff Law
2014-10-17 14:51 ` [PATCH 2/5] Add preferred_for_{size,speed} attributes Richard Sandiford
2014-10-21 14:57 ` Vladimir Makarov
2014-10-21 17:34 ` Jeff Law
2015-08-03 14:54 ` H.J. Lu
2014-10-17 14:52 ` [PATCH 3/5] Pass an alternative_mask to constrain_operands Richard Sandiford
2014-10-21 15:36 ` Vladimir Makarov
2014-10-21 17:46 ` Jeff Law [this message]
2014-10-17 14:55 ` [PATCH 4/5] Remove recog_data.enabled_alternatives Richard Sandiford
2014-10-21 14:57 ` Vladimir Makarov
2014-10-21 15:35 ` Jeff Law
2014-10-17 14:58 ` [PATCH 5/5] Use preferred_for_speed in i386.md Richard Sandiford
2014-10-17 16:59 ` Uros Bizjak
2014-10-21 15:08 ` Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54469937.9080001@redhat.com \
--to=law@redhat.com \
--cc=Ganesh.Gopalasubramanian@amd.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=markus@trippelsdorf.de \
--cc=richard.sandiford@arm.com \
--cc=ubizjak@gmail.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).