From: Jeff Law <law@redhat.com>
To: jb999@gmx.de, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Add missing requirement to crossmodule-indircall-1a.c
Date: Wed, 22 Oct 2014 21:34:00 -0000 [thread overview]
Message-ID: <54481F9E.8080802@redhat.com> (raw)
In-Reply-To: <trinity-ba9e6b40-4891-4853-a4f7-af1d2152a6b5-1413915705542@msvc031>
On 10/21/14 12:21, jb999@gmx.de wrote:
> "Jeff Law" <law@redhat.com>:
>> On 10/21/14 16:13, Haswell wrote:
>>> The additional source must have the same requirement crossmodule-indircall-1.c has.
>>>
>>> * crossmodule-indircall-1a.c: Add missing requirement.
>> Why? When used by crossmodule-indircall-1.c we'll have already tested
>> the marker and when used by itself, it does nothing.
>
>> So I don't see why you think a marker is needed for this source file.
>
> When configuring --disable-lto it gets compiled twice:
>
> FAIL: gcc.dg/tree-prof/crossmodule-indircall-1a.c compilation, -fprofile-generate -D_PROFILE_GENERATE
> UNRESOLVED: gcc.dg/tree-prof/crossmodule-indircall-1a.c execution, -fprofile-generate -D_PROFILE_GENERATE
> UNRESOLVED: gcc.dg/tree-prof/crossmodule-indircall-1a.c compilation, -fprofile-use -D_PROFILE_USE
> UNRESOLVED: gcc.dg/tree-prof/crossmodule-indircall-1a.c execution, -fprofile-use -D_PROFILE_USE
I'd recommend looking deeper. I believe that file should be collapsing
down to main () { return 0; } when LTO is not enabled.
jeff
next prev parent reply other threads:[~2014-10-22 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 18:23 jb999
2014-10-22 21:34 ` Jeff Law [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-05 20:30 jb999
2015-01-15 8:13 ` Jeff Law
2015-01-15 8:29 ` Jeff Law
2014-10-23 14:35 jb999
2014-10-24 20:18 ` Jeff Law
2014-10-21 16:15 Haswell
2014-10-21 18:12 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54481F9E.8080802@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jb999@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).