From: Tobias Burnus <burnus@net-b.de>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
"fortran@gcc.gnu.org List" <fortran@gcc.gnu.org>
Subject: Re: [PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C
Date: Thu, 23 Oct 2014 22:48:00 -0000 [thread overview]
Message-ID: <54498580.5020109@net-b.de> (raw)
In-Reply-To: <871tpylhzc.fsf@redhat.com>
Hi Manuel,
Dodji Seketeli wrote:
> Sorry, I forgot to make it clear that I have no power to approve the
> line-map changes. I just gave my casual point view; so please take it
> for what it is worth.
>
> I am CC-ing Tom and Jason who can approve this.
And I have a minor nit, which I forgot in my original review - even
though I had spotted it before: In gfc_format_decoder, you are mixing
space and tab indention.
Tobias
next prev parent reply other threads:[~2014-10-23 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 21:28 Manuel López-Ibáñez
2014-10-17 7:25 ` Tobias Burnus
2014-10-23 11:14 ` Dodji Seketeli
2014-10-23 19:12 ` Dodji Seketeli
2014-10-23 22:48 ` Tobias Burnus [this message]
2014-10-24 16:18 ` Manuel López-Ibáñez
2014-11-28 16:55 ` Manuel López-Ibáñez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54498580.5020109@net-b.de \
--to=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=lopezibanez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).