From: Georg-Johann Lay <avr@gjlay.de>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Denis Chertykov <chertykov@gmail.com>, Jeff Law <law@redhat.com>
Subject: Re: [patch,avr,4.9] Fix PR63633 ICEs for expanders colliding hard-regs
Date: Tue, 28 Oct 2014 12:55:00 -0000 [thread overview]
Message-ID: <544F9045.3020709@gjlay.de> (raw)
In-Reply-To: <544F8D44.1060000@gjlay.de>
Am 10/28/2014 01:34 PM, schrieb Georg-Johann Lay:
> Middle-end might come up with hard registers as operands for expanders which
> clobber respective hard regs. This patch uses freshly created pseudos for
> respective expander operands and emits pseudo <-> hard move insn.
>
> Ok for 4.9.2?
p.s.: testsuite passes without new regressions
> It's not yet for trunk because avr trunk backend is currently broken.
>
> Johann
>
> gcc/
> PR63633
> * config/avr/avr-protos.h (regmask): New inline function.
> (avr_fix_inputs, avr_emit3_fix_outputs): New protos.
> * config/avr/avr.c (avr_fix_operands, avr_move_fixed_operands)
> (avr_fix_inputs, avr_emit3_fix_outputs): New functions.
> * config/avr/avr-fixed.md (mulqq3_nomul, muluqq3_nomul)
> (mul<ALL2QA>3, mul<ALL4A>3, <usdiv><ALL1Q>3, <usdiv><ALL2QA>3)
> (<usdiv><ALL4A>3, round<ALL124QA>3): Fix input operands.
> * config/avr/avr-dimode.md (add<ALL8>3, sub<ALL8>3)
> (<ss_addsub><ALL8S>3, <us_addsub><ALL8U>3, cbranch<ALL8>4)
> (<di_shifts><ALL8>3, <any_extend>mulsidi3): Fix input operands.
> * config/avr/avr.md (mulqi3_call, mulhi3_call, mulsi3, mulpsi3)
> (mulu<QIHI>si3, muls<QIHI>si3, mulohisi3, <any_extend>mulhisi3)
> (usmulhisi3, <any_extend>mulhi3_highpart, mulsqipsi3)
> (fmul, fmuls, fmulsu): Fix operands. Turn insn into expander as
> needed.
>
> gcc/testsuite/
> PR63633
> * gcc.target/avr/torture/pr63633-ice-mult.c: New test.
next prev parent reply other threads:[~2014-10-28 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 12:34 Georg-Johann Lay
2014-10-28 12:55 ` Georg-Johann Lay [this message]
2014-10-30 7:25 ` Denis Chertykov
2014-10-30 11:05 ` Georg-Johann Lay
2014-10-30 11:11 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544F9045.3020709@gjlay.de \
--to=avr@gjlay.de \
--cc=chertykov@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).