From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10381 invoked by alias); 29 Oct 2014 10:53:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10372 invoked by uid 89); 29 Oct 2014 10:53:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f179.google.com Received: from mail-wi0-f179.google.com (HELO mail-wi0-f179.google.com) (209.85.212.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 29 Oct 2014 10:53:34 +0000 Received: by mail-wi0-f179.google.com with SMTP id h11so4200330wiw.0 for ; Wed, 29 Oct 2014 03:53:31 -0700 (PDT) X-Received: by 10.194.170.167 with SMTP id an7mr11854205wjc.57.1414580011343; Wed, 29 Oct 2014 03:53:31 -0700 (PDT) Received: from [192.168.10.150] (net-37-117-142-149.cust.vodafonedsl.it. [37.117.142.149]) by mx.google.com with ESMTPSA id l10sm18302176wif.20.2014.10.29.03.53.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Oct 2014 03:53:30 -0700 (PDT) Message-ID: <5450C728.3080004@gnu.org> Date: Wed, 29 Oct 2014 10:59:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jakub Jelinek CC: Phil Muldoon , DJ Delorie , Alexandre Oliva , Ralf Wildenhues , "Joseph S. Myers" , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 5/5] add libcc1 References: <53D9CA7B.3040709@redhat.com> <5436504B.8060902@redhat.com> <54385676.4000004@redhat.com> <5449FC98.1060404@redhat.com> <544A8162.1090107@redhat.com> <544E9CE5.602@redhat.com> <544FD432.8090004@redhat.com> <20141029102817.GP10376@tucnak.redhat.com> <5450C376.6000206@gnu.org> <20141029105132.GS10376@tucnak.redhat.com> In-Reply-To: <20141029105132.GS10376@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg03051.txt.bz2 On 10/29/2014 11:51 AM, Jakub Jelinek wrote: > On Wed, Oct 29, 2014 at 11:37:42AM +0100, Paolo Bonzini wrote: >> >> >> On 10/29/2014 11:28 AM, Jakub Jelinek wrote: >>> If this passes bootstrap/regtest, is it ok for trunk (should fix >>> two bootstrap issues)? Is the >>> https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02936.html >>> patch ok too (that one already tested; another bootstrap issue)? >> >> Both seem okay, though I'd have to look at the whole thread to >> understand what libcc1 is. :) > > It is a library for communication between the debugger and > a GCC plugin (and the plugin itself). So, the library is > dlopened into GDB and the plugin that links against that library > is dlopened by GCC when GDB asks the library it dlopened to > run the compiler with the plugin. > >> Just two questions: >> >> 1) what's the issue that you need to disable asan for? > > -fsanitize=address generally doesn't work or doesn't work too well, > if the binary is not built with -fsanitize=address, but shared library > dlopened into it is. So, we want to avoid instrumenting plugins > that way (we already don't instrument lto-plugin for that reason, > because ld might not be asan instrumented, and libcc1 is similar case, > when gdb dlopens the library, it might not be instrumented either). Thanks for explaining. I can see intuitively why that could be a problem... >> 2) why is GMPLIB not handled in the same way? > > The only problem is that system.h includes gmp.h, so we need a way > to find that header. I think libcc1 doesn't use any functions from gmp > itself, so if gmp.h can be included, GMPLIB isn't really needed. Ah, got it. Is it hard to move the inclusion to the actual users? Paolo