From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3091 invoked by alias); 29 Oct 2014 21:20:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3022 invoked by uid 89); 29 Oct 2014 21:20:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Oct 2014 21:20:27 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9TLKOtZ017887 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Oct 2014 17:20:24 -0400 Received: from [10.3.113.140] (ovpn-113-140.phx2.redhat.com [10.3.113.140]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9TLKNmO009493; Wed, 29 Oct 2014 17:20:23 -0400 Message-ID: <54515A17.3060400@redhat.com> Date: Wed, 29 Oct 2014 23:42:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Bernd Schmidt , GCC Patches Subject: Re: The nvptx port [7/11+] Inform the port about call arguments References: <54451994.9070209@codesourcery.com> <54451C57.5020705@codesourcery.com> <5446CC00.9000009@redhat.com> <5446D037.8030607@codesourcery.com> <5446D5CD.6080204@redhat.com> <5446D8FE.3030404@codesourcery.com> <5447F392.6050909@redhat.com> <544FACE7.8030102@codesourcery.com> In-Reply-To: <544FACE7.8030102@codesourcery.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg03153.txt.bz2 On 10/28/14 08:49, Bernd Schmidt wrote: > On 10/22/2014 08:12 PM, Jeff Law wrote: >> Yea, let's keep your approach. Just wanted to explore a bit since the >> PA seems to have a variety of similar characteristics. > > Here's an updated version of the patch. I experimented a little with ptx > calling conventions and ran into an arg that had to be moved with > memcpy, which exposed an ordering problem - all call_args were added to > the memcpy call. So the invocation of the hook had to be moved downwards > a bit, and the calculation of the return value needs to happen after it > (since nvptx_function_value needs to know whether we are actually trying > to construct a call at the moment). > > Bootstrapped and tested on x86_64-linux, ok? OK. Jeff