From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24759 invoked by alias); 4 Nov 2014 17:26:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24748 invoked by uid 89); 4 Nov 2014 17:26:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 04 Nov 2014 17:26:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA4HQ8eo017986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 4 Nov 2014 12:26:09 -0500 Received: from pike.twiddle.home (vpn1-7-223.ams2.redhat.com [10.36.7.223]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sA4HQ1jr004305; Tue, 4 Nov 2014 12:26:06 -0500 Message-ID: <54590C19.40208@redhat.com> Date: Tue, 04 Nov 2014 17:26:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andrew MacLeod , gcc-patches CC: Jeff Law , Richard Biener Subject: Re: [patch] Provide a can_compare_and_swap_p target hook. References: <5458FE9C.2090409@redhat.com> In-Reply-To: <5458FE9C.2090409@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00210.txt.bz2 On 11/04/2014 05:28 PM, Andrew MacLeod wrote: > + bool > + default_can_compare_and_swap_p (machine_mode mode, bool allow_libcall) > + { > + return can_compare_and_swap_p (mode, allow_libcall); > + } This is silly. I think the problem you point out can be better fixed by moving the can_compare_and_swap_p prototype elsewhere. r~